fix(compiler): exclude empty styles from emitted metadata#45459
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): exclude empty styles from emitted metadata#45459crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
013b289 to
03036a3
Compare
crisbeto
commented
Mar 28, 2022
packages/compiler-cli/src/ngtsc/annotations/component/src/resources.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/partial_evaluator/src/interface.ts
Outdated
Show resolved
Hide resolved
atscott
approved these changes
Mar 28, 2022
packages/compiler-cli/src/ngtsc/annotations/component/src/resources.ts
Outdated
Show resolved
Hide resolved
atscott
previously approved these changes
Mar 28, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: size-tracking
jessicajaniuk
previously approved these changes
Mar 28, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: size-tracking
clydin
reviewed
Mar 29, 2022
packages/compiler-cli/src/ngtsc/annotations/component/src/resources.ts
Outdated
Show resolved
Hide resolved
6a165eb to
d96b413
Compare
a3db212 to
b017ff8
Compare
clydin
reviewed
Mar 29, 2022
b017ff8 to
7fef191
Compare
alxhub
previously approved these changes
Apr 22, 2022
7fef191 to
fac358e
Compare
Excludes styles that resolve to empty strings from the emitted metadata so that they don't result in empty `<style>` tags at runtime. Fixes angular#31191.
fac358e to
07ee054
Compare
Member
Author
|
Merge assistance: this had all the necessary approvals, but they were reset after I rebased. I also had to change one of the size check files, because the size was reduced slightly. |
jelbourn
approved these changes
May 3, 2022
Contributor
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: global-approvers
Contributor
|
This PR was merged into the repository by commit bb8d709. |
Contributor
|
Due to conflicts with 13.3.x, I only merged this into main. Let me know if you want to do a patch port! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excludes styles that resolve to empty strings from the emitted metadata so that they don't result in empty
<style>tags at runtime.Fixes #31191.