feat(router): Add ability to return UrlTree with NavigationBehaviorOptions from guards
#45023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ac4a45 to
69e0965
Compare
69e0965 to
026813a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Results from running migration the migration internally: cl/427481595 |
026813a to
bfca0cf
Compare
Contributor
Author
atscott
commented
Feb 9, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Looks great, just added a few comments.
e19d04e to
78ca5eb
Compare
aaab2ac to
c7a13d5
Compare
c7a13d5 to
94aca9f
Compare
94aca9f to
42d58d3
Compare
…rOptions` from guards Returning `UrlTree` from a guard was a convenient new feature added to the `Router`. However, it does not have feature-parity with the old `router.navigate(...); return false;` pattern. The most common use-case for this feature is to redirect to a new page _without_ updating the URL from the initially attempted navigation. For example, rendering a 404 page when the user does not have access privelages to a route. Fixes angular#17004 Fixes angular#27148 BREAKING CHANGE: Guards can now return `RedirectCommand` for redirects in addition to `UrlTree`. Code which expects only `boolean` or `UrlTree` values in `Route` types will need to be adjusted.
42d58d3 to
850c3b8
Compare
jessicajaniuk
approved these changes
Mar 11, 2024
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Author
Contributor
Author
|
This PR was merged into the repository by commit 8735af0. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning
UrlTreefrom a guard was a convenient new feature added tothe
Router. However, it does not have feature-parity with the oldrouter.navigate(...); return false;pattern. The most common use-casefor this feature is to redirect to a new page without updating the URL
from the initially attempted navigation. For example, rendering a 404
page when the user does not have access privelages to a route.
Fixes #27148