fix(forms): Make some minor fixups for forward-compatibility with typed forms#44540
Closed
dylhunn wants to merge 1 commit intoangular:masterfrom
Closed
fix(forms): Make some minor fixups for forward-compatibility with typed forms#44540dylhunn wants to merge 1 commit intoangular:masterfrom
dylhunn wants to merge 1 commit intoangular:masterfrom
Conversation
0af4b7b to
bf0f433
Compare
AndrewKushnir
approved these changes
Jan 4, 2022
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM (just one minor comment) 👍
Contributor
There was a problem hiding this comment.
Should we use AbstractControl instead of any here (like we have it for the c2 form control)?
…ed forms. Make the following fixes: * When submitting the entire migration in a disabled state, I commented out more code than strictly required * Responding to some final review comments caused two conditions to become flipped * Always use explicit checks instead of boolean corecion * Fix one missed any cast in a test case
Contributor
Author
|
This PR was merged into the repository by commit f7aa937. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the following fixes:
anycast in a test case.Targeting minor because the migration was merged into minor.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information