docs: rewrite introduction to dependency injection#44466
docs: rewrite introduction to dependency injection#44466ileil wants to merge 1 commit intoangular:mainfrom
Conversation
303a826 to
4f653ff
Compare
|
You can preview 4f653ff at https://pr44466-4f653ff.ngbuilds.io/. |
|
You can preview bc5b9ba at https://pr44466-bc5b9ba.ngbuilds.io/. |
There was a problem hiding this comment.
Line 61: There is a specific way to enter an em dash in Cider.
|
You can preview 76446c8 at https://pr44466-76446c8.ngbuilds.io/. |
|
You can preview f4425bb at https://pr44466-f4425bb.ngbuilds.io/. |
|
You can preview 746483f at https://pr44466-746483f.ngbuilds.io/. |
|
You can preview f1c9e1b at https://pr44466-f1c9e1b.ngbuilds.io/. |
3da66f1 to
82cf550
Compare
|
You can preview cfa0a57 at https://pr44466-cfa0a57.ngbuilds.io/. |
|
You can preview 3484489 at https://pr44466-3484489.ngbuilds.io/. |
|
You can preview d1ee786 at https://pr44466-d1ee786.ngbuilds.io/. |
AndrewKushnir
left a comment
There was a problem hiding this comment.
@ileil thanks for updating the content 👍 I've left a few comments, please let me know if any additional info is needed.
I also noticed that the CI is failing and the failures are related to the changes in this PR. Please let me know if you need help debugging them.
aio/content/examples/dependency-injection-in-action/src/app/parent-finder.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This comment is still relevant: these references point nowhere, since the corresponding <a> elements were removed. I think we can just drop these from here as well.
There was a problem hiding this comment.
This content duplicates the title of this section. I think it might be better to say "Learn more" here (and in other cases below):
| <p class="card-footer">Understanding Dependency Injection</p> | |
| <p class="card-footer">Learn more</p> |
There was a problem hiding this comment.
This is the style writers are following. I'll keep them as is for consistency for now. Will bring this up in the next doc meeting.
There was a problem hiding this comment.
Ok, thanks. Btw, it's different on the main page (which makes sense to me): https://angular.io/docs
aio/content/guide/inject-object.md
Outdated
There was a problem hiding this comment.
Note: I think the file should be renamed from "inject-object.md" to something else, since the content talks about other types of content aside from objects.
There was a problem hiding this comment.
Btw, I don't think we had that page at all in our Google Doc.
There was a problem hiding this comment.
You're right. This is an obsolete file which I kept in the repo but removed from the navigation, in case we need to reuse some content from this file. I just removed it from the repo.
|
You can preview 2a96eab at https://pr44466-2a96eab.ngbuilds.io/. |
AndrewKushnir
left a comment
There was a problem hiding this comment.
@ileil thanks for additional updates. The content looks good from technical perspective, for I LGTM it. It'd be great if someone can review from the docs perspective as well.
Before landing the PR we should also make sure the CI is "green" and all commits are merged into one (or a few commits).
Thank you.
There was a problem hiding this comment.
FYI the backticks are displayed as is in the description: https://pr44466-2a96eab.ngbuilds.io/guide/dependency-injection-overview. We should probably remove them from here.
There was a problem hiding this comment.
Removed backticks from the doc cards.
|
You can preview 9b3f6a5 at https://pr44466-9b3f6a5.ngbuilds.io/. |
|
You can preview fd0b3ff at https://pr44466-fd0b3ff.ngbuilds.io/. |
|
You can preview ce62b59 at https://pr44466-ce62b59.ngbuilds.io/. |
|
You can preview 4aa2689 at https://pr44466-4aa2689.ngbuilds.io/. |
Refactored the DI section to improve doc quality, reduce cognitive load and drive consistency. - Added an overview with prerequisites and doc cards that point to rest of the DI content - Added introduction topic with topic purpose, value proposition and "fail fast" - Broke apart complex concepts into simpler tasks - Unified tone and language for each topic - Added new content based on SME feedback - Deleted obsolete content
|
You can preview 298f592 at https://pr44466-298f592.ngbuilds.io/. |
|
This PR was merged into the repository by commit 0920a15. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Rewriting dependency injection introduction to comply with new documentation templates.