feat(common): add injection token for default date pipe timezone by crisbeto · Pull Request #43611 · angular/angular

crisbeto · 2021-09-27T16:16:43Z

Adds a new injection token called DATE_PIPE_DEFAULT_TIMEZONE that allows for the default timezone for all DatePipe instances to be specified.

Fixes #43031.

petebacondarwin

This is great! I love the use of @Optional to avoid any breaking change for direct users of the DataPipe.

packages/common/src/pipes/date_pipe.ts

mary-poppins · 2021-09-27T19:41:26Z

You can preview 77e82a8 at https://pr43611-77e82a8.ngbuilds.io/.
You can preview 54afbf0 at https://pr43611-54afbf0.ngbuilds.io/.

packages/common/src/pipes/date_pipe.ts

crisbeto · 2021-09-27T20:30:47Z

The feedback has been addressed.

mary-poppins · 2021-09-27T20:40:29Z

You can preview 9d17447 at https://pr43611-9d17447.ngbuilds.io/.

petebacondarwin

Ideally we should fix the type of the injected param, but if not possible then LGTM.

crisbeto · 2021-10-06T17:24:28Z

@alxhub the feedback has been addressed.

dylhunn · 2021-10-06T18:54:51Z

Presubmit is passing: http://test/OCL:401278522:BASE:401291859:1633543923861:f2e6d38f

packages/common/src/pipes/date_pipe.ts

Adds a new injection token called `DATE_PIPE_DEFAULT_TIMEZONE` that allows for the default timezone for all `DatePipe` instances to be specified. Fixes angular#43031.

alxhub

Reviewed-for: public-api

dylhunn · 2021-10-06T20:27:12Z

This doesn't need another presubmit run, since all changes since the last are docs-only

petebacondarwin

Reviewed-for: public-api

atscott

reviewed-for: public-api

dylhunn · 2021-10-06T20:53:11Z

This PR was merged into the repository by commit adf4481.

angular-automatic-lock-bot · 2021-11-06T16:06:56Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

google-cla bot added the cla: yes label Sep 27, 2021

crisbeto changed the title ~~feat(common); add injection token for default date pipe timezone~~ feat(common): add injection token for default date pipe timezone Sep 27, 2021

crisbeto force-pushed the 43031/date-pipe-timezone branch from 77e82a8 to 54afbf0 Compare September 27, 2021 16:32

crisbeto marked this pull request as ready for review September 27, 2021 17:23

pullapprove bot requested review from alxhub and petebacondarwin September 27, 2021 17:24

crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: major This PR is targeted for the next major release labels Sep 27, 2021

ngbot bot modified the milestone: Backlog Sep 27, 2021

petebacondarwin suggested changes Sep 27, 2021

View reviewed changes

packages/common/src/pipes/date_pipe.ts Outdated Show resolved Hide resolved

packages/common/src/pipes/date_pipe.ts Outdated Show resolved Hide resolved

petebacondarwin added the aio: preview label Sep 27, 2021

petebacondarwin reviewed Sep 27, 2021

View reviewed changes

packages/common/src/pipes/date_pipe.ts Outdated Show resolved Hide resolved

crisbeto force-pushed the 43031/date-pipe-timezone branch from 54afbf0 to 9d17447 Compare September 27, 2021 20:30

petebacondarwin approved these changes Sep 30, 2021

View reviewed changes

crisbeto removed the aio: preview label Oct 6, 2021

crisbeto force-pushed the 43031/date-pipe-timezone branch 2 times, most recently from 73c3c2a to f6ba84c Compare October 6, 2021 16:44

crisbeto added action: merge The PR is ready for merge by the caretaker action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 6, 2021

crisbeto modified the milestones: Backlog, v13 Feature Freeze Oct 6, 2021

crisbeto force-pushed the 43031/date-pipe-timezone branch 2 times, most recently from 8b946d9 to bd83bce Compare October 6, 2021 18:06

alxhub reviewed Oct 6, 2021

View reviewed changes

packages/common/src/pipes/date_pipe.ts Outdated Show resolved Hide resolved

feat(common): add injection token for default date pipe timezone

79ad47a

Adds a new injection token called `DATE_PIPE_DEFAULT_TIMEZONE` that allows for the default timezone for all `DatePipe` instances to be specified. Fixes angular#43031.

crisbeto force-pushed the 43031/date-pipe-timezone branch from bd83bce to 79ad47a Compare October 6, 2021 20:20

alxhub approved these changes Oct 6, 2021

View reviewed changes

pullapprove bot requested review from IgorMinar, atscott, jelbourn and jessicajaniuk October 6, 2021 20:34

petebacondarwin approved these changes Oct 6, 2021

View reviewed changes

atscott approved these changes Oct 6, 2021

View reviewed changes

dylhunn closed this in adf4481 Oct 6, 2021

angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2021

Conversation

crisbeto commented Sep 27, 2021

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented Sep 27, 2021

Uh oh!

Uh oh!

crisbeto commented Sep 27, 2021

Uh oh!

mary-poppins commented Sep 27, 2021

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

crisbeto commented Oct 6, 2021

Uh oh!

dylhunn commented Oct 6, 2021

Uh oh!

Uh oh!

alxhub left a comment

Choose a reason for hiding this comment

Uh oh!

dylhunn commented Oct 6, 2021

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

atscott left a comment

Choose a reason for hiding this comment

Uh oh!

dylhunn commented Oct 6, 2021

Uh oh!

angular-automatic-lock-bot bot commented Nov 6, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants