Skip to content

Conversation

@crisbeto
Copy link
Member

In #43281 I had to add a resolutionsfor typescript due to the api-extractor being locked down to an older version. Now that it has been updated, we don't need the workaround anymore.

@google-cla google-cla bot added the cla: yes label Sep 24, 2021
@crisbeto crisbeto marked this pull request as ready for review September 24, 2021 05:44
@pullapprove pullapprove bot requested a review from gkalpak September 24, 2021 05:44
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release labels Sep 24, 2021
@ngbot ngbot bot modified the milestone: Backlog Sep 24, 2021
@alan-agius4
Copy link
Contributor

@crisbeto can you please address the conflicts?

@crisbeto crisbeto force-pushed the api-extractor-workaround branch from e1e5ffb to 39cea2a Compare September 24, 2021 18:07
@crisbeto
Copy link
Member Author

Rebased.

Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 27, 2021
In angular#43281 I had to add a `resolutions`for `typescript` due to the `api-extractor` being locked down to an older version. Now that it has been updated, we don't need the workaround anymore.
@crisbeto crisbeto force-pushed the api-extractor-workaround branch from 39cea2a to 719e0d4 Compare September 27, 2021 17:53
@alxhub alxhub closed this in f055a88 Sep 27, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants