Hey @arturovt, sorry for the delay in answering! Just wanted to mention that this PR is likely introducing a relatively big breaking change from behavior standpoint where more views would be processed by change detection. We will need to look into this more and see if there similar approaches and/or whether we need to have a flag to opt-in/opt-out of this behavior. I will keep this thread updated, but I don't have any ETA at this moment. Thank you.

presubmit

Hi @arturovt, @AndrewKushnir and I investigated this today. Here's a summary of our findings:

• We've determined that this is the right fix due to how NgModel is doing the Promise.resolve. The fact that the Promise is used causes the setValue to be called after the child template executes.
• Ideally, this Promise would not even exist (if it didn't we wouldn't have this issue in the first place because the setValue would be called at the correct time). Unfortunately, that's a change we can't make because it would be too breaking.
• We were concerned a bit about the performance implications - while NgModel already triggers another change detection by using the Promise, it doesn't necessarily result in anything being checked (because there might not be anything that's dirty). We determined that this shouldn't be an issue for two reasons:
  • First, anyone using ngModel and showing the value in the template would already need to be calling markForCheck to get the right value displayed (and what would be the point of the control without displaying the current value).
  • Second, if it really does have a performance impact for people in rare cases, we can add an option on NgModel to not call markForCheck
• There was only one failure in all of Google's internal tests. We've sent out a change request to update the test to be more correct.

Could you please rebase this PR so we can proceed with merging?

Hey @atscott . I’ll reopen the PR since I have another fork.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}