Skip to content

build(zone.js): zone.js should output esm format for fesm2015 bundles#39203

Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:zone-apf-fix
Closed

build(zone.js): zone.js should output esm format for fesm2015 bundles#39203
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:zone-apf-fix

Conversation

@JiaLiPassion
Copy link
Contributor

@JiaLiPassion JiaLiPassion commented Oct 9, 2020 •
edited
Loading

Zone.js support Angular package format since 0.11, but the fesm2015 bundles
are not esm format, it still use umd bundle which is not correct, in this PR,
a new esm bundle output is added in rollup_bundle rule under tools, so
zone.js can use the new rule to generate esm bundles.

Before this PR, fesm2015/zone.js is a umd bundle.


(function (factory) {
    typeof define === 'function' && define.amd ? define(factory) :
    factory();
}((function () { 'use strict';

    /**
     * @license
     * Copyright Google LLC All Rights Reserved.
     *
     * Use of this source code is governed by an MIT-style license that can be
     * found in the LICENSE file at https://angular.io/license
     */
    const Zone$1 = (function (global) {
        const performance = global['performance'];
        ...

now it is a esm bundle.

const Zone$1 = (function (global) {
    const performance = global['performance'];
    ...

@google-cla google-cla bot added the cla: yes label Oct 9, 2020
@JiaLiPassion JiaLiPassion added the target: major This PR is targeted for the next major release label Oct 9, 2020
IgorMinar
IgorMinar approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me. Can you please clarify why we have the minified debug output there? is it actually necessary for something?

@JiaLiPassion
build(zone.js): zone.js should output esm format for fesm2015 bundles
91b6b21 
Zone.js support `Angular package format` since `0.11`, but the `fesm2015` bundles
are not `esm` format, it still use `umd` bundle which is not correct, in this PR,
a new `esm` bundle output is added in `rollup_bundle` rule under `tools`, so
zone.js can use the new rule to generate `esm` bundles.
@atscott atscott added the area: zones Issues related to zone.js label Oct 13, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 13, 2020
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Oct 15, 2020
@atscott atscott closed this in 497af77 Oct 15, 2020
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 15, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@mhevery mhevery mhevery approved these changes

@IgorMinar IgorMinar IgorMinar approved these changes

@kyliau kyliau kyliau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

5 participants

@JiaLiPassion @mhevery @IgorMinar @kyliau @atscott