fix(zone.js): add missing types field in package.json#38585
Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Closed
fix(zone.js): add missing types field in package.json#38585JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Conversation
JoostK
reviewed
Aug 26, 2020
50328b7 to
90e88ed
Compare
gkalpak
suggested changes
Aug 26, 2020
99ac50b to
8b77caa
Compare
alan-agius4
reviewed
Aug 27, 2020
alan-agius4
reviewed
Aug 27, 2020
8b77caa to
c671dd5
Compare
gkalpak
reviewed
Aug 27, 2020
mhevery
approved these changes
Sep 1, 2020
Contributor
mhevery
left a comment
There was a problem hiding this comment.
Please resolve' other comments before merging.
gkalpak
approved these changes
Sep 2, 2020
Member
gkalpak
left a comment
There was a problem hiding this comment.
LGTM with one comment/suggestion.
4e837f8 to
9d3fa9f
Compare
Close angular#38584 In zone.js 0.11.1, the `types` field is missing in the `package.json`, the reason is in zone.js 0.11.0, the `files` field is used to specify the types, but it cause the npm package not contain any bundles issue, so zone.js 0.11.1 remove the `files` field, which cause the `type` definition gone. This PR concat the `zone.js.d.ts`, `zone.configurations.api.ts`, `zone.api.extensions.ts` types into a single `zone.d.ts` file.
9d3fa9f to
470d555
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #38584
In zone.js 0.11.1, the
typesfield is missing in thepackage.json,the reason is in zone.js 0.11.0, the
filesfield is used to specify thetypes, but it cause the npm package not contain any bundles issue, so zone.js
0.11.1 remove the
filesfield, which cause thetypedefinition gone.This PR concat the
zone.js.d.ts,zone.configurations.api.ts,zone.api.extensions.tstypes into a single
zone.js.d.tsfile.