fix(ivy): fix class inheritance detection for ES5 code in ngtsc#28773
Closed
gkalpak wants to merge 1 commit intoangular:masterfrom
Closed
fix(ivy): fix class inheritance detection for ES5 code in ngtsc#28773gkalpak wants to merge 1 commit intoangular:masterfrom
ngtsc#28773gkalpak wants to merge 1 commit intoangular:masterfrom
Conversation
aa0a29d to
7421f24
Compare
16 tasks
Previously, `ngtsc` detected class inheritance in a way that only worked in TS or ES2015 code. As a result, inheritance would not be detected for code in ES5 format, such as when running `ngtsc` through `ngcc` to transform old-style Angular code to ivy format. This commit fixes it by delegating class inheritance detection to the current `ReflectionHost`, which is able to correctly interpret the used code format.
7421f24 to
f1c1c7e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Docs have been added / updated (for bug fixes / features)PR Type
What is the current behavior?
ngtscdetects class inheritance in a way that only works in TS or ES2015 code. As a result, inheritance will not be detected for code in ES5 format, such as when runningngtscthroughngccto transform old-style Angular code to ivy format.Related issue: #28643
What is the new behavior?
This PR fixes the issue by delegating class inheritance detection to the current
ReflectionHost, which is able to correctly interpret the used code format.Does this PR introduce a breaking change?