We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

CLAs look good, thanks!

There is any update on this yet?

A lot of issues are related to that #10981 #26672 #13807 and this issue has been around for +2 years. If someone could review that MR that'd be fantastic 🙏

I'd appreciate this fix being merged too! 👍

This fix would be fantastic 🙏

When the estimated time this fix will come? I'm in need of this fix and don't want to edit the packages myself due to wanting future fixes.

We do not want to change all of our empty routes and we still need that functionality.
So I've decided to create a patch and apply it directly into the node_modules code...

Even though it's faaar from being ideal, I can't help to think that it might be useful for others so use this with caution ⚠️ but here it is:

1. Create a postinstall hook within your package.json scripts attribute: "postinstall": "patch -p1 --forward < patches/patch-angular-router.diff || true"

2. Create a folder patches at the root of your projects

3. Create the following file

diff --git a/node_modules/@angular/router/fesm5/router.js b/node_modules/@angular/router/fesm5/router.js
index 5cd391e..ce5eccf 100755
--- a/node_modules/@angular/router/fesm5/router.js
+++ b/node_modules/@angular/router/fesm5/router.js
@@ -2513,7 +2513,7 @@ var ApplyRedirects = /** @class */ (function () {
         return segments.length === 0 && !segmentGroup.children[outlet];
     };
     ApplyRedirects.prototype.expandSegmentAgainstRoute = function (ngModule, segmentGroup, routes, route, paths, outlet, allowRedirects) {
-        if (getOutlet(route) !== outlet) {
+        if (getOutlet(route) !== outlet && !isLazyRootWithEmptyPath(route)) {
             return noMatch(segmentGroup);
         }
         if (route.redirectTo === undefined) {
@@ -2809,6 +2809,9 @@ function isEmptyPathRedirect(segmentGroup, segments, r) {
     }
     return r.path === '' && r.redirectTo !== undefined;
 }
+function isLazyRootWithEmptyPath(route) {
+    return !!route.loadChildren && route.path === '' && getOutlet(route) === PRIMARY_OUTLET;
+}
 function getOutlet(route) {
     return route.outlet || PRIMARY_OUTLET;
 }

Is there anything that can be done to speed things up?

Indeed - if there's anything the community can do to help this move ahead, please let us know.

We have a set of huge apps with some horrible janky router workarounds we'd love to remove. Somehow encountered this issue with nearly every Angular app I've ever worked on.

Thanks so much for the PR, by the way, @attilavegh !

Seems this bugfix is really needed. I went to this issue too.
Could someone review this? :/

Edit:
Seems this did not cover my use case since I edited the file .../node_modules/@angular/router/fesm5/router.js with this changes, but still have an issue here:

function getChildConfig(route) {
    if (route.children) {
        return route.children;
    }
    if (route.loadChildren) {
        return route._loadedConfig.routes; // <- Cannot read property 'routes' of undefined
    }
    return [];
}

Edit2:
Also seems not to work with named paths (with outlet option). When I use named paths, did not resolve to any route

I have being debugged this at @angular/router level and I found that here:

So since first(function(s) { return !!s; }), will be called on first truthy value, which means other matched routes will not be executed.
I am trying to implement a fix on this but it's being hard since I am not very familiar with the structure.
@jasonaden @matsko @IgorMinar do you have any ideia on how to fix this?

Edit:
If we comment this if block

Edit2:
The delay after concateAll workaround could be related with this
Be wary of backpressure when the source emits at a faster pace than inner observables complete! found here https://www.learnrxjs.io/operators/combination/concatall.html#

Any updates on this?

@matsko @mhevery May anyone from angular correctly implement this fix?

@attilavegh I created my own PR with for that problem because your doesn't fix issue in case like this:

  {
    path: '',
    outlet: 'footer',
    component: LinksBarComponent
  },
  {
   path: '',
   loadChildren: () => import('./modules/main/main.module').then(m => m.MainModule)
  },

@joselcvarela Thank you very much! Your comment gave me right direction

@asvishnyakov So will this fix the following issue

In my app-routing i have

  {
    path: 'cookie',
    outlet: 'popup',
    component: CookieLawComponent
  },

and if I try loading the site directly using https://localhost:4200/(popup:cookie) it throws an error of

zone-evergreen.js:797 Uncaught Error: Uncaught (in promise): TypeError: Cannot read property 'routes' of undefined
TypeError: Cannot read property 'routes' of undefined

@dottodot It should

We are too having this nasty TypeError: Cannot read property 'routes' of undefined problem with the Router and lazy loading with outlet.

Can someone from the Angular team comment on whether this PR is going to be merged during our lifetime?

This issue was originally reported more than 3 years ago in Angular 2.0.0-rc.5. It was marked as critical more than 2 years ago, and still we have no idea if fix for it is even planned?
I know that Angular team has been pretty busy with Ivy and all, but still, an update would be nice.

Closing for a couple reasons:

• The repository this PR came from was deleted so merging wouldn't work
• As mentioned in fix(router): lazy loaded empty root path loads with auxiliary outlet #25483 (comment) and fix(router): lazy loaded empty root path loads with auxiliary outlet #25483 (comment), this only addresses the issue in one specific case, but does not fix it in others.
• fix(router): support lazy loading for named outlets #32688 is a more complete fix. The PR also uses combineLatest which would be preferable to delay after concatAll as mentioned in fix(router): lazy loaded empty root path loads with auxiliary outlet #25483 (comment) for performance reasons.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}