Skip to content

fix(animations): retain state styling for nodes that are moved around#23534

Closed
matsko wants to merge 1 commit intoangular:masterfrom
matsko:fix_animation_move
Closed

fix(animations): retain state styling for nodes that are moved around#23534
matsko wants to merge 1 commit intoangular:masterfrom
matsko:fix_animation_move

Conversation

@matsko
Copy link
Contributor

@matsko matsko commented Apr 24, 2018

No description provided.

@mary-poppins
Copy link

You can preview 05008ab at https://pr23534-05008ab.ngbuilds.io/.

@matsko matsko force-pushed the fix_animation_move branch from 05008ab to 77da010 Compare April 30, 2018 22:44
@mary-poppins
Copy link

You can preview 77da010 at https://pr23534-77da010.ngbuilds.io/.

@matsko matsko added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels May 1, 2018
@IgorMinar IgorMinar closed this in 65211f4 May 2, 2018
@stmihai
Copy link

stmihai commented Sep 24, 2018

The fix doesn't seem to work for child nodes.
In [animation_integration_spec.ts - 'should retain state styles when the underlying DOM structure changes even if there are no insert/remove animations'], if you wrap the item in another div and move the animation to that div, like this:
`<div *ngFor="let item of items">
<div class="item" [@color]="colorExp">{{ item }}

` you will see that item "1" loses background color after sorting.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: animations cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants