Skip to content

Drop use of the Intl API to improve browser support #18284

Closed
ocombe wants to merge 3 commits intoangular:masterfrom
ocombe:fix-intl-api-10809
Closed

Drop use of the Intl API to improve browser support #18284
ocombe wants to merge 3 commits intoangular:masterfrom
ocombe:fix-intl-api-10809

Conversation

@ocombe
Copy link
Copy Markdown
Contributor

@ocombe ocombe commented Jul 21, 2017

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature

What is the current behavior?

We need the intl API for i18n pipes

Issue Number: #10809, #9524, #7008, #9324, #7590, #6724, #3429, #17576, #17478, #17319, #17200, #16838, #16624, #16625, #16591, #14131, #12632, #11376, #11187

What is the new behavior?

We don't need the intl API anymore, we extract and use data from CLDR instead.

Date pipe:

  • new formats (breaking change), see comparative document
  • new optional parameter: timezone that lets you specify the timezone for a date (it will shift the date values based on the locale timezone so that you see it as it was from this other timezone).
  • new optional parameter: locale that lets you use a specific locale for this pipe (instead of using the default LOCALE_ID)

Plural pipe:

  • new optional parameter: locale that lets you use a specific locale for this pipe (instead of using the default LOCALE_ID)

Decimal pipe:

  • new optional parameter: locale that lets you use a specific locale for this pipe (instead of using the default LOCALE_ID)

Percent pipe:

  • new optional parameter: locale that lets you use a specific locale for this pipe (instead of using the default LOCALE_ID)

Currency pipe:

  • the parameter symbolDisplay is no longer a boolean (it still works with a boolean, but it prints a warning to let you know that it changed), it’s now taking the values code, symbol, or symbol-narrow (the default is still code) which gives you access to more options for to show your currencies (e.g. the canadian dollar with the code CAD has the symbol CA$ and the symbol-narrow $).
  • new optional parameter: locale that lets you use a specific locale for this pipe (instead of using the default LOCALE_ID)

Does this PR introduce a breaking change?

[x] Yes

All i18n pipes have been updated to not require the intl API anymore. Some results might vary, see the document to update from v4 to v5 for more information.

TODO

  • write a document to update from v4 to v5

@ocombe ocombe added area: i18n Issues related to localization and internationalization state: WIP labels Jul 21, 2017
@ocombe ocombe requested review from IgorMinar and vicb July 21, 2017 18:14
@ocombe ocombe changed the title Fix intl api 10809 feat(core): remove dependency to intl API Jul 21, 2017
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment on dedup

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: new RegExp('_', 'g') -> /-/g

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currentLocale -> normalizedLocale

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isOldChrome is only used by intl api, when I first did the PR, I removed the old pipes and the tests for them. But then I moved them as deprecated pipes instead, and forgot to revert this change. Doing it now.

@ocombe ocombe force-pushed the fix-intl-api-10809 branch 3 times, most recently from 1053613 to d513368 Compare July 25, 2017 19:24
@angular angular deleted a comment from mary-poppins Jul 25, 2017
@angular angular deleted a comment from mary-poppins Jul 25, 2017
@angular angular deleted a comment from mary-poppins Jul 25, 2017
@ocombe ocombe force-pushed the fix-intl-api-10809 branch from d513368 to c33247f Compare July 25, 2017 19:59
@angular angular deleted a comment from mary-poppins Jul 25, 2017
@ocombe ocombe force-pushed the fix-intl-api-10809 branch from c33247f to 052a61a Compare July 25, 2017 20:31
@mary-poppins
Copy link
Copy Markdown

You can preview 052a61a at https://pr18284-052a61a.ngbuilds.io/.

@angular angular deleted a comment from mary-poppins Jul 25, 2017
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS CODE IS GENERATED - DO NOT MODIFY

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts:

  • I think we can remove all of the {..., ...},
  • I think we can also remove the need to import the std objects and merge the full object

Because we are going to use an API to access the data (which goal is to abstract the storage format).

Also the registerLocaleData(...) could help here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a nested key here and below ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet, just thinking about future things that we might add

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment explaining what you do pls

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is probably no need to duplicate this logic as many time as we have locales

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to generate arrays instead of obj ?
What is the diff in size ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: I donc speak ar but the files look really similar for different regions (the QA part). Is there any check in place to make sure we do not duplicate the same data multiple times ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not between different locales no, but it doesn't really matter since people will only import one of them, not all

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will prevent devs to have to buy a new SSD only to npm install Angular.
The check is easy enough. Please git it a try to see how much we can save.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meme remarque encore ici: probablement beaucoup de chose en commun avec fr-* (sauf currency et peut etre numbers). Would be NICE to check what we can factor.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An array would make sense here instead of an obj.

Copy link
Copy Markdown
Contributor Author

@ocombe ocombe Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just saved 6.2ko minified by optimizing this file!

@angular angular deleted a comment from mary-poppins Aug 17, 2017
@angular angular deleted a comment from mary-poppins Aug 17, 2017
@angular angular deleted a comment from mary-poppins Aug 17, 2017
@angular angular deleted a comment from mary-poppins Aug 17, 2017
@angular angular deleted a comment from mary-poppins Aug 17, 2017
@angular angular deleted a comment from mary-poppins Aug 17, 2017
@angular angular deleted a comment from mary-poppins Aug 17, 2017
@ocombe ocombe force-pushed the fix-intl-api-10809 branch 2 times, most recently from 2ccff14 to eac0b99 Compare August 17, 2017 17:45
@ocombe ocombe changed the title Remove dependency to intl API Drop use of the Intl API to improve browser support Aug 17, 2017
@ocombe ocombe added target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 17, 2017
@ocombe ocombe force-pushed the fix-intl-api-10809 branch from eac0b99 to 97c6974 Compare August 18, 2017 07:38
@mary-poppins
Copy link
Copy Markdown

You can preview 97c6974 at https://pr18284-97c6974.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

You can preview 154def8 at https://pr18284-154def8.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

You can preview 591dea5 at https://pr18284-591dea5.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

You can preview 3ae3d61 at https://pr18284-3ae3d61.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

You can preview 9613115 at https://pr18284-9613115.ngbuilds.io/.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum ?

BREAKING CHANGE: Because of multiple bugs and browser inconsistencies, we have dropped the intl api in favor of data exported from the Unicode Common Locale Data Repository (CLDR).
Unfortunately we had to change the i18n pipes (date, number, currency, percent) and there are some breaking changes.

1. I18n pipes
* Breaking change:
  - By default Angular now only contains locale data for the language `en-US`, if you set the value of `LOCALE_ID` to another locale, you will have to import new locale data for this language because we don't use the intl API anymore.

* Features:
  - you don't need to use the intl polyfill for Angular anymore.
  - all i18n pipes now have an additional last parameter `locale` which allows you to use a specific locale instead of the one defined in the token `LOCALE_ID` (whose value is `en-US` by default).
  - the new locale data extracted from CLDR are now available to developers as well and can be used through an API (which should be especially useful for library authors).
  - you can still use the old pipes for now, but their names have been changed and they are no longer included in the `CommonModule`. To use them, you will have to import the `DeprecatedI18NPipesModule` after the `CommonModule` (the order is important):

  ```ts
  import { NgModule } from '@angular/core';
  import { CommonModule, DeprecatedI18NPipesModule } from '@angular/common';

  @NgModule({
    imports: [
      CommonModule,
      // import deprecated module after
      DeprecatedI18NPipesModule
    ]
  })
  export class AppModule { }
  ```

  Dont forget that you will still need to import the intl API polyfill if you want to use those deprecated pipes.


2. Date pipe
* Breaking changes:
  - the predefined formats (`short`, `shortTime`, `shortDate`, `medium`, ...) now use the patterns given by CLDR (like it was in AngularJS) instead of the ones from the intl API. You might notice some changes, e.g. `shortDate` will be `8/15/17` instead of `8/15/2017` for `en-US`.
  - the narrow version of eras is now `GGGGG` instead of `G`, the format `G` is now similar to `GG` and `GGG`.
  - the narrow version of months is now `MMMMM` instead of `L`, the format `L` is now the short standalone version of months.
  - the narrow version of the week day is now `EEEEE` instead of `E`, the format `E` is now similar to `EE` and `EEE`.
  - the timezone `z` will now fallback to `O` and output `GMT+1` instead of the complete zone name (e.g. `Pacific Standard Time`), this is because the quantity of data required to have all the zone names in all of the existing locales is too big.
  - the timezone `Z` will now output the ISO8601 basic format, e.g. `+0100`, you should now use `ZZZZ` to get `GMT+01:00`.

  | Field type | Format        | Example value         | v4 | v5            |
  |------------|---------------|-----------------------|----|---------------|
  | Eras       | Narrow        | A for AD              | G  | GGGGG         |
  | Months     | Narrow        | S for September       | L  | MMMMM         |
  | Week day   | Narrow        | M for Monday          | E  | EEEEE         |
  | Timezone   | Long location | Pacific Standard Time | z  | Not available |
  | Timezone   | Long GMT      | GMT+01:00             | Z  | ZZZZ          |

* Features
  - new predefined formats `long`, `full`, `longTime`, `fullTime`.
  - the format `yyy` is now supported, e.g. the year `52` will be `052` and the year `2017` will be `2017`.
  - standalone months are now supported with the formats `L` to `LLLLL`.
  - week of the year is now supported with the formats `w` and `ww`, e.g. weeks `5` and `05`.
  - week of the month is now supported with the format `W`, e.g. week `3`.
  - fractional seconds are now supported with the format `S` to `SSS`.
  - day periods for AM/PM now supports additional formats `aa`, `aaa`, `aaaa` and `aaaaa`. The formats `a` to `aaa` are similar, while `aaaa` is the wide version if available (e.g. `ante meridiem` for `am`), or equivalent to `a` otherwise, and `aaaaa` is the narrow version (e.g. `a` for `am`).
  - extra day periods are now supported with the formats `b` to `bbbbb` (and `B` to `BBBBB` for the standalone equivalents), e.g. `morning`, `noon`, `afternoon`, ....
  - the short non-localized timezones are now available with the format `O` to `OOOO`. The formats `O` to `OOO` will output `GMT+1` while the format `OOOO` will be `GMT+01:00`.
  - the ISO8601 basic time zones are now available with the formats `Z` to `ZZZZZ`. The formats `Z` to `ZZZ` will output `+0100`, while the format `ZZZZ` will be `GMT+01:00` and `ZZZZZ` will be `+01:00`.

* Bug fixes
  - the date pipe will now work exactly the same across all browsers, which will fix a lot of bugs for safari and IE.
  - eras can now be used on their own without the date, e.g. the format `GG` will be `AD` instead of `8 15, 2017 AD`.


3. Currency pipe
* Breaking change:
  - the default value for `symbolDisplay` is now `symbol` instead of `code`. This means that by default you will see `$4.99` for `en-US` instead of `USD4.99` previously.
  
* Deprecation:
  - the second parameter of the currency pipe (`symbolDisplay`) is no longer a boolean, it now takes the values `code`, `symbol` or `symbol-narrow`. A boolean value is still valid for now, but it is deprecated and it will print a warning message in the console.

* Features:
  - you can now choose between `code`, `symbol` or `symbol-narrow` which gives you access to more options for some currencies (e.g. the canadian dollar with the code `CAD` has the symbol `CA$` and the symbol-narrow `$`).


4. Percent pipe
* Breaking change
  - if you don't specify the number of digits to round to, the local format will be used (and it usually rounds numbers to 0 digits, instead of not rounding previously), e.g. `{{ 3.141592 | percent }}` will output `314%` for the locale `en-US` instead of `314.1592%` previously.


Fixes angular#10809, angular#9524, angular#7008, angular#9324, angular#7590, angular#6724, angular#3429, angular#17576, angular#17478, angular#17319, angular#17200, angular#16838, angular#16624, angular#16625, angular#16591, angular#14131, angular#12632, angular#11376, angular#11187
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: i18n Issues related to localization and internationalization cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants