@DzmitryShylovich what is the status of your pull request?

This will not fix the issue, the test case passed only because NaN is the first synchronously emitted value, try change the test case to:

it('should return NaN when given NaN and the latest returned value is NaN', () => {
    const subject = new BehaviorSubject<any>(null);
    pipe.transform(subject);
    subject.next(NaN);
    expect(pipe.transform(subject)).toBeNaN();
    expect(pipe.transform(subject)).toBeNaN();
});

And it will fail.

You guys could retake this PR since Dzmitry was banned long ago.

@ericmartinezr Just linked my PR here.

@ericmartinezr Dzmitry is banned long ago, why? I do not know the history, what happened?

@splincode Just a quick search is enough.

• Search is:issue commenter:DzmitryShylovich sort:created-desc in issues you'll find his last replied issue is #15791;
• Check the issue and get the reply time April 5, 2017;
• Open the Gitter history on April 5, 2017;
• Search for DzmitryShylovich in browser, found he survived that day;
• Open the Gitter history on April 6, 2017;
• Search for DzmitryShylovich in browser again, found the explanation.

@channel: we've banned @DzmitryShylovich permanently for repeated violations of our Code of Conduct. This means on both gitter and angular's github presence.

reminder: we are 100% not screwing around about our Code of Conduct: https://github.com/angular/code-of-conduct/blob/master/CODE_OF_CONDUCT.md - Please read it, abide by it, and remember that we are trying to keep this as an inclusive community, for everyone.

And you can then check any history message before that date.

@trotyl Do you mean that they just blocked it? But for what? So you need to close all its PR?

So you need to close all its PR?

It's Angular team's job, nothing to do with me...

@robwormald Could you close the PR's? Because the PR data will no longer be supported by anyone.

About 10 open requests:
https://github.com/angular/angular/pulls/DzmitryShylovich%20

we've banned @DzmitryShylovich permanently for repeated violations of our Code of Conduct. This means on both gitter and angular's github presence.

reminder: we are 100% not screwing around about our Code of Conduct: https://github.com/angular/code-of-conduct/blob/master/CODE_OF_CONDUCT.md - Please read it, abide by it, and remember that we are trying to keep this as an inclusive community, for everyone.

closing in favor of #22305

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}