Skip to content

feat(router): routerLink add tabindex attribute #13094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vicb merged 1 commit into from
Dec 9, 2016
Merged

feat(router): routerLink add tabindex attribute #13094

vicb merged 1 commit into from
Dec 9, 2016

Conversation

@DzmitryShylovich
Copy link
Contributor

@DzmitryShylovich DzmitryShylovich commented Nov 25, 2016

Fixes #10895

vicb
vicb reviewed Dec 3, 2016
View reviewed changes
modules/@angular/router/src/directives/router_link.ts Outdated
Copy link
Contributor

@vicb vicb Dec 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls revert

@vicb vicb added area: router action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 3, 2016
@DzmitryShylovich
Copy link
Contributor Author

DzmitryShylovich commented Dec 3, 2016

done

@vicb
Copy link
Contributor

vicb commented Dec 5, 2016

Could you please rebase - will be merged after the next minor release.
Thanks

@vicb vicb added state: blocked pr_state: LGTM and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 5, 2016
@vicb
Copy link
Contributor

vicb commented Dec 5, 2016

Thanks !

Ready to be merged for 2.4.0-beta

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Dec 9, 2016
@vicb vicb merged commit a006c14 into angular:master Dec 9, 2016
@akloeber akloeber mentioned this pull request Jan 24, 2019
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vicb vicb vicb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: router cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

routerLink outside a link should have a tabindex property

3 participants

@DzmitryShylovich @vicb @googlebot