-
Notifications
You must be signed in to change notification settings - Fork 27.1k
Control flow schematic: ngIfThen + ngIfElse inputs are not migrated #53254
Copy link
Copy link
Closed
Labels
area: migrationsIssues related to `ng update`/`ng generate` migrationsIssues related to `ng update`/`ng generate` migrationscore: control flowIssues related to the built-in control flow (@if, @for, @switch)Issues related to the built-in control flow (@if, @for, @switch)
Milestone
Description
Which @angular/* package(s) are the source of the bug?
core
Is this a regression?
No
Description
Input:
<ng-template
[ngIf]="mode === 'foo'"
[ngIfThen]="foo"
[ngIfElse]="bar"
></ng-template>
<ng-template #foo>
Foo
</ng-template>
<ng-template #bar>
Bar
</ng-template>
Output:
@if (mode === 'foo') {
<ng-template
[ngIfThen]="foo"
[ngIfElse]="bar"
></ng-template>
} @else {
Bar
}
<ng-template #foo>
Foo
</ng-template>
<ng-template #bar>
Bar
</ng-template>
Expected output:
@if (mode === 'foo') {
Foo
} @else {
Bar
}
This is a similar issue to #53251
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 17.0.3
Node: 20.9.0
Package Manager: pnpm 8.11.0
OS: darwin arm64
Angular: 17.1.0-next.1+sha-c9f8e75
... core
Package Version
-------------------------------------------------------------
@angular-devkit/architect 0.1700.1
@angular-devkit/build-angular 17.0.3
@angular-devkit/core 17.0.3
@angular-devkit/schematics 17.0.3
@angular/animations 17.0.4
@angular/cdk 17.0.1
@angular/cli 17.0.3
@angular/common 17.0.4
@angular/compiler 17.0.4
@angular/compiler-cli 17.0.4
@angular/elements 17.0.4
@angular/forms 17.0.4
@angular/google-maps 15.2.9
@angular/language-service 17.0.4
@angular/localize 17.0.4
@angular/platform-browser 17.0.4
@angular/platform-browser-dynamic 17.0.4
@angular/router 17.0.4
@angular/service-worker 17.0.4
@schematics/angular 17.0.3
ng-packagr 17.0.2
rxjs 7.8.0
typescript 5.2.2
webpack 5.88.2
zone.js 0.14.2
Anything else?
I am running this against the latest snapshot build of the main branch via setting "@angular/core": "angular/core-builds#17.1.0-next.1+fadfee4" in the package.json
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area: migrationsIssues related to `ng update`/`ng generate` migrationsIssues related to `ng update`/`ng generate` migrationscore: control flowIssues related to the built-in control flow (@if, @for, @switch)Issues related to the built-in control flow (@if, @for, @switch)