-
Notifications
You must be signed in to change notification settings - Fork 27.1k
Control flow schematic: ngIfElse input is not removed after migration #53230
Copy link
Copy link
Closed
Labels
area: migrationsIssues related to `ng update`/`ng generate` migrationsIssues related to `ng update`/`ng generate` migrationscore: control flowIssues related to the built-in control flow (@if, @for, @switch)Issues related to the built-in control flow (@if, @for, @switch)state: has PR
Milestone
Description
Which @angular/* package(s) are the source of the bug?
core
Is this a regression?
No
Description
Input:
<ng-template
[ngIf]="false"
[ngIfElse]="fooTemplate"
[ngTemplateOutlet]="barTemplate"
>
</ng-template>
<ng-template #fooTemplate>
Foo
</ng-template>
<ng-template #barTemplate>
Bar
</ng-template>
Output:
@if (false) {
<ng-template
[ngIfElse]="fooTemplate"
[ngTemplateOutlet]="barTemplate"
>
</ng-template>
} @else {
Foo
}
<ng-template #fooTemplate>
Foo
</ng-template>
<ng-template #barTemplate>
Bar
</ng-template>
Expected ([ngIfElse]="fooTemplate" + associated ng-template should be removed):
@if (false) {
<ng-template
[ngTemplateOutlet]="barTemplate"
>
</ng-template>
} @else {
Foo
}
<ng-template #barTemplate>
Bar
</ng-template>
Please provide a link to a minimal reproduction of the bug
N/A
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 17.0.3
Node: 20.9.0
Package Manager: pnpm 8.11.0
OS: darwin arm64
Angular: 17.1.0-next.1+sha-f1b7d40
... core
Package Version
-------------------------------------------------------------
@angular-devkit/architect 0.1700.1
@angular-devkit/build-angular 17.0.3
@angular-devkit/core 17.0.3
@angular-devkit/schematics 17.0.3
@angular/animations 17.0.4
@angular/cdk 17.0.1
@angular/cli 17.0.3
@angular/common 17.0.4
@angular/compiler 17.0.4
@angular/compiler-cli 17.0.4
@angular/elements 17.0.4
@angular/forms 17.0.4
@angular/google-maps 15.2.9
@angular/language-service 17.0.4
@angular/localize 17.0.4
@angular/platform-browser 17.0.4
@angular/platform-browser-dynamic 17.0.4
@angular/router 17.0.4
@angular/service-worker 17.0.4
@schematics/angular 17.0.3
ng-packagr 17.0.2
rxjs 7.8.0
typescript 5.2.2
webpack 5.88.2
zone.js 0.14.2
Anything else?
Noting that I have installed the latest dev build against the main branch via "@angular/core": "angular/core-builds#17.1.0-next.1+f1b7d40", to get the latest fixes
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area: migrationsIssues related to `ng update`/`ng generate` migrationsIssues related to `ng update`/`ng generate` migrationscore: control flowIssues related to the built-in control flow (@if, @for, @switch)Issues related to the built-in control flow (@if, @for, @switch)state: has PR