fix(bazel): fix incorrect rollup plugin method signature#41101
fix(bazel): fix incorrect rollup plugin method signature#41101jbedard wants to merge 1 commit intoangular:masterfrom
Conversation
Update the resolveBazel method signature to align with the rollup plugin resolveId API: https://rollupjs.org/guide/en/#resolveid
alexeagle
left a comment
There was a problem hiding this comment.
Seems like Angular ought to use ng-packagr to package itself, as that's the supported solution in angular-cli.
That would allow deprecation and removal of the @angular/bazel package?
If ng-packagr doesn't do all the right things, seems like it should be fixed there rather than maintain this competing thing I wrote 😞
|
I'm not sure how compatible ng-packagr would be with things like |
|
There's some work for sure - I imagine the layering would have to be changed somewhat if |
|
@petebacondarwin note that this doesn't actually fix #35149. That is to upgrade the rollup peerdep where this fixes a crash once you do upgrade rollup. So this will be required if #35149 is done, but I'd hope this one can be merged first either way... |
Update the resolveBazel method signature to align with the rollup plugin resolveId API: https://rollupjs.org/guide/en/#resolveid PR Close #41101
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update the resolveBazel method signature to align with the rollup plugin
resolveId API: https://rollupjs.org/guide/en/#resolveid
PR Type
Bugfix
What is the current behavior?
The incorrect plugin signature causes a crash in rollup >=2.29.0 after the extra argument was added: rollup/rollup@1ad8289#diff-2651238122dc82e0e84b4e3cb1499b8cbd4c01a21a36c9c2fae5812e95cd8ec8R233
What is the new behavior?
It doesn't crash
Does this PR introduce a breaking change?
No
Other information
I hope minor bug fixes are still accepted for
@angular/bazel?#35149 suggests updating the
@angular/bazelpeer deps to more modern versions of rollup + plugins which I'd also like to do if such changes are still accepted? However this PR is a minor fix without any breaking changes so I thought I'd start with this...