fix(language-service): Add plugin option to force strictTemplates#41062
Closed
kyliau wants to merge 1 commit intoangular:masterfrom
Closed
fix(language-service): Add plugin option to force strictTemplates#41062kyliau wants to merge 1 commit intoangular:masterfrom
kyliau wants to merge 1 commit intoangular:masterfrom
Conversation
alxhub
approved these changes
Mar 3, 2021
atscott
approved these changes
Mar 3, 2021
2152479 to
b221adf
Compare
b221adf to
2b5eee9
Compare
zarend
approved these changes
Mar 3, 2021
2b5eee9 to
d8551f4
Compare
This commit adds a new configuration option, `forceStrictTemplates` to the language service plugin to allow users to force enable `strictTemplates`. This is needed so that the Angular extension can be used inside Google without changing the underlying compiler options in the `ng_module` build rule.
d8551f4 to
f4f7e64
Compare
14 tasks
This was referenced Mar 15, 2021
Closed
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new configuration option,
forceStrictTemplatesto thelanguage service plugin to allow users to force enable
strictTemplates.This is needed so that the Angular extension can be used inside Google without
changing the underlying compiler options in the
ng_modulebuild rule.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information