feat(router): Add more find-tuned control in routerLinkActiveOptions#40303
Closed
atscott wants to merge 1 commit intoangular:masterfrom
Closed
feat(router): Add more find-tuned control in routerLinkActiveOptions#40303atscott wants to merge 1 commit intoangular:masterfrom
routerLinkActiveOptions#40303atscott wants to merge 1 commit intoangular:masterfrom
Conversation
|
You can preview 469c542 at https://pr40303-469c542.ngbuilds.io/. |
|
You can preview 0a9178b at https://pr40303-0a9178b.ngbuilds.io/. |
cb3dee0 to
fe1ce31
Compare
routerLinkActiveOptions
|
You can preview fe1ce31 at https://pr40303-fe1ce31.ngbuilds.io/. |
|
You can preview 44e5b5f at https://pr40303-44e5b5f.ngbuilds.io/. |
Contributor
|
Looks like this causes a few size regressions that need updating. |
14 tasks
petebacondarwin
approved these changes
Jan 9, 2021
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM - a few nits you can consider.
This was referenced Mar 15, 2021
Closed
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds more configurability to the
Router#isActivemethodand
RouterLinkActive#routerLinkActiveOptions.It allows tuning individual match options for query params and the url
tree, which were either both partial or both exact matches in the past.
Additionally, it also allows matching against the fragment and matrix
parameters.
fixes #13205
BREAKING CHANGE:
The type of the
RouterLinkActive.routerLinkActiveOptionsinput wasexpanded to allow more fine-tuned control. Code that previously read
this property may need to be updated to account for the new type.
Additional note on the breaking change:
I found no places where
routerLinkActiveOptionswas read in g3. So while the type change is technically breaking, it's possible that nobody will be affected.