fix(common): make Location.normalize() return the correct path when the base path contains characters that interfere with regex syntax. (#49181)

wartab · AndrewKushnir · commit f0e926074df1 · 2023-02-27T10:02:33.000-08:00
Fix the function stripping the base path from the URL, as the current implementation uses the base path as part of a regex, which wrongly makes paths fails that contain characters such as a parenthesis (example: C:/Users/MyUser(Test)/project). Fixes #49179 PR Close #49181
diff --git a/packages/common/src/location/location.ts b/packages/common/src/location/location.ts
@@ -301,9 +301,14 @@ export function createLocation() {
 }
 
 function _stripBasePath(basePath: string, url: string): string {
-  return basePath && new RegExp(`^${basePath}([/;?#]|$)`).test(url) ?
-      url.substring(basePath.length) :
-      url;
+  if (!basePath || !url.startsWith(basePath)) {
+    return url;
+  }
+  const strippedUrl = url.substring(basePath.length);
+  if (strippedUrl === '' || ['/', ';', '?', '#'].includes(strippedUrl[0])) {
+    return strippedUrl;
+  }
+  return url;
 }
 
 function _stripIndexHtml(url: string): string {
diff --git a/packages/common/test/location/location_spec.ts b/packages/common/test/location/location_spec.ts
@@ -286,5 +286,18 @@ describe('Location Class', () => {
       expect(location.normalize(baseHref + matrixParams)).toBe(matrixParams);
       expect(location.normalize(baseHref + fragment)).toBe(fragment);
     });
+
+    it('in case APP_BASE_HREF contains characters that have special meaning in a regex', () => {
+      const baseHref = 'c:/users/name(test)/en';
+      const path = '/test-path';
+
+      TestBed.configureTestingModule({providers: [{provide: APP_BASE_HREF, useValue: baseHref}]});
+
+      const location = TestBed.inject(Location);
+
+      expect(location.normalize(path)).toBe(path);
+      expect(location.normalize(baseHref)).toBe('');
+      expect(location.normalize(baseHref + path)).toBe(path);
+    });
   });
 });
