refactor(core): calling autoDetectChanges without params works for zoneless (#55800)

atscott · atscott · commit eda86d53477d · 2024-05-15T08:46:30.000-07:00
This was mistakenly implemented automatically by the override without filling in the default value of `true` like it is for the zone-based fixture. PR Close #55800
diff --git a/packages/core/testing/src/component_fixture.ts b/packages/core/testing/src/component_fixture.ts
@@ -194,7 +194,7 @@ export class ScheduledComponentFixture<T> extends ComponentFixture<T> {
     }
   }
 
-  override detectChanges(checkNoChanges: boolean = true): void {
+  override detectChanges(checkNoChanges = true): void {
     if (!checkNoChanges) {
       throw new Error(
         'Cannot disable `checkNoChanges` in this configuration. ' +
@@ -206,7 +206,7 @@ export class ScheduledComponentFixture<T> extends ComponentFixture<T> {
     this._effectRunner.flush();
   }
 
-  override autoDetectChanges(autoDetect?: boolean | undefined): void {
+  override autoDetectChanges(autoDetect = true): void {
     if (!autoDetect) {
       throw new Error(
         'Cannot disable autoDetect after it has been enabled when using the zoneless scheduler. ' +

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ export class ScheduledComponentFixture<T> extends ComponentFixture<T> {`
`194`	`194`	`}`
`195`	`195`	`}`
`196`	`196`
`197`		`- override detectChanges(checkNoChanges: boolean = true): void {`
	`197`	`+ override detectChanges(checkNoChanges = true): void {`
`198`	`198`	`if (!checkNoChanges) {`
`199`	`199`	`throw new Error(`
`200`	`200`	'Cannot disable `checkNoChanges` in this configuration. ' +
`@@ -206,7 +206,7 @@ export class ScheduledComponentFixture<T> extends ComponentFixture<T> {`
`206`	`206`	`this._effectRunner.flush();`
`207`	`207`	`}`
`208`	`208`
`209`		`- override autoDetectChanges(autoDetect?: boolean \| undefined): void {`
	`209`	`+ override autoDetectChanges(autoDetect = true): void {`
`210`	`210`	`if (!autoDetect) {`
`211`	`211`	`throw new Error(`
`212`	`212`	`'Cannot disable autoDetect after it has been enabled when using the zoneless scheduler. ' +`