refactor(platform-browser): use performance API for async animations (#53963)

JeanMeche · alxhub · commit ed8857e46f27 · 2024-02-21T15:12:05.000-08:00
This commit adds a standard performance marker PR Close #53963
diff --git a/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json b/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
@@ -1223,15 +1223,15 @@
   {
     "name": "optimizeGroupPlayer"
   },
-  {
-    "name": "options"
-  },
   {
     "name": "parseAndConvertBindingsForDefinition"
   },
   {
     "name": "parseTimelineCommand"
   },
+  {
+    "name": "performanceMarkFeature"
+  },
   {
     "name": "processInjectorTypesWithProviders"
   },
diff --git a/packages/platform-browser/animations/async/src/providers.ts b/packages/platform-browser/animations/async/src/providers.ts
@@ -7,7 +7,7 @@
  */
 
 import {DOCUMENT} from '@angular/common';
-import {ANIMATION_MODULE_TYPE, EnvironmentProviders, makeEnvironmentProviders, NgZone, RendererFactory2} from '@angular/core';
+import {ANIMATION_MODULE_TYPE, EnvironmentProviders, makeEnvironmentProviders, NgZone, RendererFactory2, ɵperformanceMarkFeature as performanceMarkFeature} from '@angular/core';
 import {ɵDomRendererFactory2 as DomRendererFactory2} from '@angular/platform-browser';
 
 import {AsyncAnimationRendererFactory} from './async_animation_renderer';
@@ -42,6 +42,7 @@ import {AsyncAnimationRendererFactory} from './async_animation_renderer';
  */
 export function provideAnimationsAsync(type: 'animations'|'noop' = 'animations'):
     EnvironmentProviders {
+  performanceMarkFeature('NgAsyncAnimations');
   return makeEnvironmentProviders([
     {
       provide: RendererFactory2,
diff --git a/packages/platform-browser/animations/src/module.ts b/packages/platform-browser/animations/src/module.ts
@@ -5,7 +5,7 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
-import {ModuleWithProviders, NgModule, Provider} from '@angular/core';
+import {ModuleWithProviders, NgModule, Provider, ɵperformanceMarkFeature as performanceMarkFeature} from '@angular/core';
 import {BrowserModule} from '@angular/platform-browser';
 
 import {BROWSER_ANIMATIONS_PROVIDERS, BROWSER_NOOP_ANIMATIONS_PROVIDERS} from './providers';
@@ -81,6 +81,7 @@ export class BrowserAnimationsModule {
  * @publicApi
  */
 export function provideAnimations(): Provider[] {
+  performanceMarkFeature('NgEagerAnimations');
   // Return a copy to prevent changes to the original array in case any in-place
   // alterations are performed to the `provideAnimations` call results in app code.
   return [...BROWSER_ANIMATIONS_PROVIDERS];

Original file line number	Diff line number	Diff line change
`@@ -1223,15 +1223,15 @@`
`1223`	`1223`	`{`
`1224`	`1224`	`"name": "optimizeGroupPlayer"`
`1225`	`1225`	`},`
`1226`		`- {`
`1227`		`- "name": "options"`
`1228`		`- },`
`1229`	`1226`	`{`
`1230`	`1227`	`"name": "parseAndConvertBindingsForDefinition"`
`1231`	`1228`	`},`
`1232`	`1229`	`{`
`1233`	`1230`	`"name": "parseTimelineCommand"`
`1234`	`1231`	`},`
	`1232`	`+ {`
	`1233`	`+ "name": "performanceMarkFeature"`
	`1234`	`+ },`
`1235`	`1235`	`{`
`1236`	`1236`	`"name": "processInjectorTypesWithProviders"`
`1237`	`1237`	`},`