refactor(core): prevent timeout from applying to non-event animation bindings (#63393)

thePunderWoman · AndrewKushnir · commit ed6a3471091c · 2025-08-27T11:17:40.000-07:00
The 4 second removal timeout was applying in all cases, but it should only actually apply to the situation where the event binding syntax is used for animate.leave. This ensures that's the only case in which it'll apply. PR Close #63393
diff --git a/packages/core/src/animation/element_removal_registry.ts b/packages/core/src/animation/element_removal_registry.ts
@@ -65,6 +65,7 @@ export class ElementRegistry {
     const details = this.outElements.get(el) ?? {
       classes: null,
       animateFn: () => {},
+      isEventBinding: true,
     };
     details.animateFn = animateWrapperFn(el, value);
     this.outElements.set(el, details);
@@ -75,6 +76,7 @@ export class ElementRegistry {
     const details = this.outElements.get(el) ?? {
       classes: new Set<string>(),
       animateFn: (): void => {},
+      isEventBinding: false,
     };
     if (typeof value === 'function') {
       this.trackResolver(details, value);
@@ -109,8 +111,11 @@ export class ElementRegistry {
     };
     // this timeout is used to ensure elements actually get removed in the case
     // that the user forgot to call the remove callback. The timeout is cleared
-    // in the DOM renderer during the remove child process.
-    timeoutId = setTimeout(remove, maxAnimationTimeout);
+    // in the DOM renderer during the remove child process. It only applies
+    // to the event binding use case.
+    if (details.isEventBinding) {
+      timeoutId = setTimeout(remove, maxAnimationTimeout);
+    }
     details.animateFn(remove);
   }
 }
diff --git a/packages/core/src/animation/interfaces.ts b/packages/core/src/animation/interfaces.ts
@@ -67,4 +67,5 @@ export interface AnimationDetails {
   classes: Set<string> | null;
   classFns?: Function[];
   animateFn: AnimationRemoveFunction;
+  isEventBinding: boolean;
 }

Original file line number	Diff line number	Diff line change
`@@ -67,4 +67,5 @@ export interface AnimationDetails {`
`67`	`67`	`classes: Set<string> \| null;`
`68`	`68`	`classFns?: Function[];`
`69`	`69`	`animateFn: AnimationRemoveFunction;`
	`70`	`+ isEventBinding: boolean;`
`70`	`71`	`}`