fix(platform-browser): roll back HMR fix (#59557)

crisbeto · pkozlowski-opensource · commit eb0b1851f494 · 2025-01-16T12:27:51.000+01:00
Rolls back the changes from #59514 because they ended up being breaking in 1P. We can revisit the internal fix in a different way. Fixes #59558. PR Close #59557
diff --git a/packages/platform-browser/src/dom/dom_renderer.ts b/packages/platform-browser/src/dom/dom_renderer.ts
@@ -201,9 +201,6 @@ export class DomRendererFactory2 implements RendererFactory2, OnDestroy {
    * @param componentId ID of the component that is being replaced.
    */
   protected componentReplaced(componentId: string) {
-    // Destroy the renderer so the styles get removed from the DOM, otherwise
-    // they may leak back into the component together with the new ones.
-    this.rendererByCompId.get(componentId)?.destroy();
     this.rendererByCompId.delete(componentId);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -201,9 +201,6 @@ export class DomRendererFactory2 implements RendererFactory2, OnDestroy {`
`201`	`201`	`* @param componentId ID of the component that is being replaced.`
`202`	`202`	`*/`
`203`	`203`	`protected componentReplaced(componentId: string) {`
`204`		`- // Destroy the renderer so the styles get removed from the DOM, otherwise`
`205`		`- // they may leak back into the component together with the new ones.`
`206`		`- this.rendererByCompId.get(componentId)?.destroy();`
`207`	`204`	`this.rendererByCompId.delete(componentId);`
`208`	`205`	`}`
`209`	`206`	`}`