fix(core): capture stack for HMR errors (#60067)

crisbeto · kirjs · commit e601bdca8a83 · 2025-02-24T11:56:15.000-05:00
Currently we send the `message` of an error thrown during HMR. That's usually not enough so now we also capture the stack trace. Relates to angular/angular-cli#29695. PR Close #60067
diff --git a/packages/core/src/render3/hmr.ts b/packages/core/src/render3/hmr.ts
@@ -308,12 +308,13 @@ function executeWithInvalidateFallback(
   try {
     callback();
   } catch (e) {
-    const errorMessage = (e as {message?: string}).message;
+    const error = e as {message?: string; stack?: string};
 
     // If we have all the necessary information and APIs to send off the invalidation
     // request, send it before rethrowing so the dev server can decide what to do.
-    if (id !== null && errorMessage) {
-      importMeta?.hot?.send?.('angular:invalidate', {id, message: errorMessage, error: true});
+    if (id !== null && error.message) {
+      const toLog = error.message + (error.stack ? '\n' + error.stack : '');
+      importMeta?.hot?.send?.('angular:invalidate', {id, message: toLog, error: true});
     }
 
     // Throw the error in case the page doesn't get refreshed.
