Revert "fix(common): Update Location to get a normalized URL valid in case a represented URL starts with the substring equals APP_BASE_HREF" (#48461)

thePunderWoman · thePunderWoman · commit e0d62cb7346b · 2022-12-12T16:18:46.000-08:00
This reverts commit ae0efb6. PR Close #48461
diff --git a/packages/common/src/location/location.ts b/packages/common/src/location/location.ts
@@ -301,10 +301,7 @@ export function createLocation() {
 }
 
 function _stripBasePath(basePath: string, url: string): string {
-  if (basePath === url) {
-    return '';
-  }
-  return basePath && url.startsWith(basePath + '/') ? url.substring(basePath.length) : url;
+  return basePath && url.startsWith(basePath) ? url.substring(basePath.length) : url;
 }
 
 function _stripIndexHtml(url: string): string {
diff --git a/packages/common/test/location/location_spec.ts b/packages/common/test/location/location_spec.ts
@@ -266,18 +266,4 @@ describe('Location Class', () => {
       expect(location.normalize(url)).toBe(route);
     });
   });
-
-  describe('location.normalize(url) should return correct route', () => {
-    it('in case url starts with the substring equals APP_BASE_HREF', () => {
-      const baseHref = '/en';
-      const url = '/enigma';
-
-      TestBed.configureTestingModule({providers: [{provide: APP_BASE_HREF, useValue: baseHref}]});
-
-      const location = TestBed.inject(Location);
-
-      expect(location.normalize(url)).toBe(url);
-      expect(location.normalize(baseHref + url)).toBe(url);
-    });
-  });
 });

Original file line number	Diff line number	Diff line change
`@@ -301,10 +301,7 @@ export function createLocation() {`
`301`	`301`	`}`
`302`	`302`
`303`	`303`	`function _stripBasePath(basePath: string, url: string): string {`
`304`		`- if (basePath === url) {`
`305`		`- return '';`
`306`		`- }`
`307`		`- return basePath && url.startsWith(basePath + '/') ? url.substring(basePath.length) : url;`
	`304`	`+ return basePath && url.startsWith(basePath) ? url.substring(basePath.length) : url;`
`308`	`305`	`}`
`309`	`306`
`310`	`307`	`function _stripIndexHtml(url: string): string {`