fix(migrations): properly replace imports across files (#58414)

pkozlowski-opensource · alxhub · commit d504452e2f19 · 2024-10-30T09:24:06.000-07:00
This change fixes a bug where the output migration was interacting with the InputManager utility in the way that was resulting in incorrect import replacements. The fix consists of making sure that a new ImportManager instance is created for each and every file containing @output declarations. PR Close #58414
diff --git a/packages/core/schematics/migrations/output-migration/output-migration.spec.ts b/packages/core/schematics/migrations/output-migration/output-migration.spec.ts
@@ -579,6 +579,43 @@ describe('outputs', () => {
       expect(stats.counters['successRate']).toBe(1);
     });
   });
+
+  describe('non-regression', () => {
+    it('should properly process import replacements across multiple files', async () => {
+      const {fs} = await runTsurgeMigration(new OutputMigration(), [
+        {
+          name: absoluteFrom('/app.component.ts'),
+          isProgramRootFile: true,
+          contents: `
+            import {Component, Output, EventEmitter} from '@angular/core';
+
+            @Component({selector: 'app-component'})
+            export class AppComponent {
+              @Output() appOut = new EventEmitter();
+            }
+          `,
+        },
+        {
+          name: absoluteFrom('/other.component.ts'),
+          isProgramRootFile: true,
+          contents: `
+            import {Component, Output, EventEmitter} from '@angular/core';
+
+            @Component({selector: 'other-component'})
+            export class OtherComponent {
+              @Output() otherOut = new EventEmitter();
+            }
+          `,
+        },
+      ]);
+
+      for (const file of ['/app.component.ts', '/other.component.ts']) {
+        const content = fs.readFile(absoluteFrom(file)).trim();
+        const firstLine = content.split('\n')[0];
+        expect(firstLine).toBe(`import {Component, output} from '@angular/core';`);
+      }
+    });
+  });
 });
 
 async function verifyDeclaration(testCase: {before: string; after: string}) {
diff --git a/packages/core/schematics/migrations/output-migration/output-replacements.ts b/packages/core/schematics/migrations/output-migration/output-replacements.ts
@@ -68,9 +68,9 @@ export function calculateImportReplacements(info: ProgramInfo, sourceFiles: Set<
     {add: Replacement[]; addAndRemove: Replacement[]}
   > = {};
 
-  const importManager = new ImportManager();
-
   for (const sf of sourceFiles) {
+    const importManager = new ImportManager();
+
     const addOnly: Replacement[] = [];
     const addRemove: Replacement[] = [];
     const file = projectFile(sf, info);
