refactor(core): Use the nullish coalescing assignment in render3 functions (#49698)

JeanMeche · dylhunn · commit d497be7aca87 · 2023-04-05T09:45:53.000-07:00
The usage of `??=` make the code more clear & concise. PR Close #49698
diff --git a/packages/core/src/render3/hooks.ts b/packages/core/src/render3/hooks.ts
@@ -39,18 +39,17 @@ export function registerPreOrderHooks(
 
   if (ngOnChanges as Function | undefined) {
     const wrappedOnChanges = NgOnChangesFeatureImpl(directiveDef);
-    (tView.preOrderHooks || (tView.preOrderHooks = [])).push(directiveIndex, wrappedOnChanges);
-    (tView.preOrderCheckHooks || (tView.preOrderCheckHooks = []))
-        .push(directiveIndex, wrappedOnChanges);
+    (tView.preOrderHooks ??= []).push(directiveIndex, wrappedOnChanges);
+    (tView.preOrderCheckHooks ??= []).push(directiveIndex, wrappedOnChanges);
   }
 
   if (ngOnInit) {
-    (tView.preOrderHooks || (tView.preOrderHooks = [])).push(0 - directiveIndex, ngOnInit);
+    (tView.preOrderHooks ??= []).push(0 - directiveIndex, ngOnInit);
   }
 
   if (ngDoCheck) {
-    (tView.preOrderHooks || (tView.preOrderHooks = [])).push(directiveIndex, ngDoCheck);
-    (tView.preOrderCheckHooks || (tView.preOrderCheckHooks = [])).push(directiveIndex, ngDoCheck);
+    (tView.preOrderHooks ??= []).push(directiveIndex, ngDoCheck);
+    (tView.preOrderCheckHooks ??= []).push(directiveIndex, ngDoCheck);
   }
 }
 
@@ -91,25 +90,25 @@ export function registerPostOrderHooks(tView: TView, tNode: TNode): void {
     } = lifecycleHooks;
 
     if (ngAfterContentInit) {
-      (tView.contentHooks || (tView.contentHooks = [])).push(-i, ngAfterContentInit);
+      (tView.contentHooks ??= []).push(-i, ngAfterContentInit);
     }
 
     if (ngAfterContentChecked) {
-      (tView.contentHooks || (tView.contentHooks = [])).push(i, ngAfterContentChecked);
-      (tView.contentCheckHooks || (tView.contentCheckHooks = [])).push(i, ngAfterContentChecked);
+      (tView.contentHooks ??= []).push(i, ngAfterContentChecked);
+      (tView.contentCheckHooks ??= []).push(i, ngAfterContentChecked);
     }
 
     if (ngAfterViewInit) {
-      (tView.viewHooks || (tView.viewHooks = [])).push(-i, ngAfterViewInit);
+      (tView.viewHooks ??= []).push(-i, ngAfterViewInit);
     }
 
     if (ngAfterViewChecked) {
-      (tView.viewHooks || (tView.viewHooks = [])).push(i, ngAfterViewChecked);
-      (tView.viewCheckHooks || (tView.viewCheckHooks = [])).push(i, ngAfterViewChecked);
+      (tView.viewHooks ??= []).push(i, ngAfterViewChecked);
+      (tView.viewCheckHooks ??= []).push(i, ngAfterViewChecked);
     }
 
     if (ngOnDestroy != null) {
-      (tView.destroyHooks || (tView.destroyHooks = [])).push(i, ngOnDestroy);
+      (tView.destroyHooks ??= []).push(i, ngOnDestroy);
     }
   }
 }
diff --git a/packages/core/src/render3/instructions/shared.ts b/packages/core/src/render3/instructions/shared.ts
@@ -1144,12 +1144,12 @@ export function initializeDirectives(
       // We will push the actual hook function into this array later during dir instantiation.
       // We cannot do it now because we must ensure hooks are registered in the same
       // order that directives are created (i.e. injection order).
-      (tView.preOrderHooks || (tView.preOrderHooks = [])).push(tNode.index);
+      (tView.preOrderHooks ??= []).push(tNode.index);
       preOrderHooksFound = true;
     }
 
     if (!preOrderCheckHooksFound && (lifeCycleHooks.ngOnChanges || lifeCycleHooks.ngDoCheck)) {
-      (tView.preOrderCheckHooks || (tView.preOrderCheckHooks = [])).push(tNode.index);
+      (tView.preOrderCheckHooks ??= []).push(tNode.index);
       preOrderCheckHooksFound = true;
     }
 
@@ -1362,7 +1362,7 @@ export function markAsComponentHost(tView: TView, hostTNode: TNode, componentOff
   ngDevMode && assertFirstCreatePass(tView);
   ngDevMode && assertGreaterThan(componentOffset, -1, 'componentOffset must be great than -1');
   hostTNode.componentOffset = componentOffset;
-  (tView.components || (tView.components = [])).push(hostTNode.index);
+  (tView.components ??= []).push(hostTNode.index);
 }
 
 /** Caches local names and their matching directive indices for query and template lookups. */
diff --git a/packages/core/src/render3/pipe.ts b/packages/core/src/render3/pipe.ts
@@ -43,7 +43,7 @@ export function ɵɵpipe(index: number, pipeName: string): any {
     pipeDef = getPipeDef(pipeName, tView.pipeRegistry)!;
     tView.data[adjustedIndex] = pipeDef;
     if (pipeDef.onDestroy) {
-      (tView.destroyHooks || (tView.destroyHooks = [])).push(adjustedIndex, pipeDef.onDestroy);
+      (tView.destroyHooks ??= []).push(adjustedIndex, pipeDef.onDestroy);
     }
   } else {
     pipeDef = tView.data[adjustedIndex] as PipeDef<any>;

Original file line number	Diff line number	Diff line change
`@@ -39,18 +39,17 @@ export function registerPreOrderHooks(`
`39`	`39`
`40`	`40`	`if (ngOnChanges as Function \| undefined) {`
`41`	`41`	`const wrappedOnChanges = NgOnChangesFeatureImpl(directiveDef);`
`42`		`- (tView.preOrderHooks \|\| (tView.preOrderHooks = [])).push(directiveIndex, wrappedOnChanges);`
`43`		`- (tView.preOrderCheckHooks \|\| (tView.preOrderCheckHooks = []))`
`44`		`- .push(directiveIndex, wrappedOnChanges);`
	`42`	`+ (tView.preOrderHooks ??= []).push(directiveIndex, wrappedOnChanges);`
	`43`	`+ (tView.preOrderCheckHooks ??= []).push(directiveIndex, wrappedOnChanges);`
`45`	`44`	`}`
`46`	`45`
`47`	`46`	`if (ngOnInit) {`
`48`		`- (tView.preOrderHooks \|\| (tView.preOrderHooks = [])).push(0 - directiveIndex, ngOnInit);`
	`47`	`+ (tView.preOrderHooks ??= []).push(0 - directiveIndex, ngOnInit);`
`49`	`48`	`}`
`50`	`49`
`51`	`50`	`if (ngDoCheck) {`
`52`		`- (tView.preOrderHooks \|\| (tView.preOrderHooks = [])).push(directiveIndex, ngDoCheck);`
`53`		`- (tView.preOrderCheckHooks \|\| (tView.preOrderCheckHooks = [])).push(directiveIndex, ngDoCheck);`
	`51`	`+ (tView.preOrderHooks ??= []).push(directiveIndex, ngDoCheck);`
	`52`	`+ (tView.preOrderCheckHooks ??= []).push(directiveIndex, ngDoCheck);`
`54`	`53`	`}`
`55`	`54`	`}`
`56`	`55`
`@@ -91,25 +90,25 @@ export function registerPostOrderHooks(tView: TView, tNode: TNode): void {`
`91`	`90`	`} = lifecycleHooks;`
`92`	`91`
`93`	`92`	`if (ngAfterContentInit) {`
`94`		`- (tView.contentHooks \|\| (tView.contentHooks = [])).push(-i, ngAfterContentInit);`
	`93`	`+ (tView.contentHooks ??= []).push(-i, ngAfterContentInit);`
`95`	`94`	`}`
`96`	`95`
`97`	`96`	`if (ngAfterContentChecked) {`
`98`		`- (tView.contentHooks \|\| (tView.contentHooks = [])).push(i, ngAfterContentChecked);`
`99`		`- (tView.contentCheckHooks \|\| (tView.contentCheckHooks = [])).push(i, ngAfterContentChecked);`
	`97`	`+ (tView.contentHooks ??= []).push(i, ngAfterContentChecked);`
	`98`	`+ (tView.contentCheckHooks ??= []).push(i, ngAfterContentChecked);`
`100`	`99`	`}`
`101`	`100`
`102`	`101`	`if (ngAfterViewInit) {`
`103`		`- (tView.viewHooks \|\| (tView.viewHooks = [])).push(-i, ngAfterViewInit);`
	`102`	`+ (tView.viewHooks ??= []).push(-i, ngAfterViewInit);`
`104`	`103`	`}`
`105`	`104`
`106`	`105`	`if (ngAfterViewChecked) {`
`107`		`- (tView.viewHooks \|\| (tView.viewHooks = [])).push(i, ngAfterViewChecked);`
`108`		`- (tView.viewCheckHooks \|\| (tView.viewCheckHooks = [])).push(i, ngAfterViewChecked);`
	`106`	`+ (tView.viewHooks ??= []).push(i, ngAfterViewChecked);`
	`107`	`+ (tView.viewCheckHooks ??= []).push(i, ngAfterViewChecked);`
`109`	`108`	`}`
`110`	`109`
`111`	`110`	`if (ngOnDestroy != null) {`
`112`		`- (tView.destroyHooks \|\| (tView.destroyHooks = [])).push(i, ngOnDestroy);`
	`111`	`+ (tView.destroyHooks ??= []).push(i, ngOnDestroy);`
`113`	`112`	`}`
`114`	`113`	`}`
`115`	`114`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ export function ɵɵpipe(index: number, pipeName: string): any {`
`43`	`43`	`pipeDef = getPipeDef(pipeName, tView.pipeRegistry)!;`
`44`	`44`	`tView.data[adjustedIndex] = pipeDef;`
`45`	`45`	`if (pipeDef.onDestroy) {`
`46`		`- (tView.destroyHooks \|\| (tView.destroyHooks = [])).push(adjustedIndex, pipeDef.onDestroy);`
	`46`	`+ (tView.destroyHooks ??= []).push(adjustedIndex, pipeDef.onDestroy);`
`47`	`47`	`}`
`48`	`48`	`} else {`
`49`	`49`	`pipeDef = tView.data[adjustedIndex] as PipeDef<any>;`