refactor(core): fix MockRenderer in unit tests. (#63936)

JeanMeche · thePunderWoman · commit d0c7ea8491b7 · 2025-09-19T14:50:08.000Z
This allows us to drop a test only check in the runtime. PR Close #63936
diff --git a/packages/core/src/render3/component_ref.ts b/packages/core/src/render3/component_ref.ts
@@ -324,14 +324,8 @@ export class ComponentFactory<T> extends AbstractComponentFactory<T> {
         );
 
         // ---- element instruction
-
-        // TODO(crisbeto): in practice `hostElement` should always be defined, but there are some
-        // tests where the renderer is mocked out and `undefined` is returned. We should update the
-        // tests so that this check can be removed.
-        if (hostElement) {
-          setupStaticAttributes(hostRenderer, hostElement, hostTNode);
-          attachPatchData(hostElement, rootLView);
-        }
+        setupStaticAttributes(hostRenderer, hostElement, hostTNode);
+        attachPatchData(hostElement, rootLView);
 
         // TODO(pk): this logic is similar to the instruction code where a node can have directives
         createDirectivesInstances(rootTView, rootLView, hostTNode);
diff --git a/packages/core/test/acceptance/renderer_factory_spec.ts b/packages/core/test/acceptance/renderer_factory_spec.ts
@@ -209,13 +209,15 @@ describe('renderer factory lifecycle', () => {
       })
       class AnimComp {}
 
-      const rendererFactory = new MockRendererFactory(['setProperty']);
-
+      let rendererFactory!: MockRendererFactory;
       TestBed.configureTestingModule({
         providers: [
           {
             provide: RendererFactory2,
-            useValue: rendererFactory,
+            useFactory: (doc: Document) => {
+              rendererFactory = new MockRendererFactory(doc, ['setProperty']);
+              return rendererFactory;
+            },
             deps: [DOCUMENT],
           },
         ],
@@ -245,12 +247,15 @@ describe('renderer factory lifecycle', () => {
       visible = true;
     }
 
-    const rendererFactory = new MockRendererFactory(['destroy', 'createElement']);
+    let rendererFactory!: MockRendererFactory;
     TestBed.configureTestingModule({
       providers: [
         {
           provide: RendererFactory2,
-          useValue: rendererFactory,
+          useFactory: (doc: Document) => {
+            rendererFactory = new MockRendererFactory(doc, ['destroy', 'createElement']);
+            return rendererFactory;
+          },
           deps: [DOCUMENT],
         },
       ],
@@ -545,12 +550,15 @@ export class MockRendererFactory implements RendererFactory2 {
   lastRenderer: any;
   private _spyOnMethods: string[];
 
-  constructor(spyOnMethods?: string[]) {
+  constructor(
+    private document: Document,
+    spyOnMethods?: string[],
+  ) {
     this._spyOnMethods = spyOnMethods || [];
   }
 
   createRenderer(hostElement: RElement | null, rendererType: RendererType2 | null): Renderer2 {
-    const renderer = (this.lastRenderer = new MockRenderer(this._spyOnMethods));
+    const renderer = (this.lastRenderer = new MockRenderer(this._spyOnMethods, this.document));
     return renderer;
   }
 }
@@ -561,21 +569,26 @@ class MockRenderer implements Renderer2 {
 
   destroyNode: ((node: any) => void) | null = null;
 
-  constructor(spyOnMethods: string[]) {
+  constructor(
+    spyOnMethods: string[],
+    private document: Document,
+  ) {
     spyOnMethods.forEach((methodName) => {
       this.spies[methodName] = spyOn(this as any, methodName).and.callThrough();
     });
   }
 
   destroy(): void {}
   createComment(value: string): Comment {
-    return document.createComment(value);
+    return this.document.createComment(value);
   }
   createElement(name: string, namespace?: string | null): Element {
-    return namespace ? document.createElementNS(namespace, name) : document.createElement(name);
+    return namespace
+      ? this.document.createElementNS(namespace, name)
+      : this.document.createElement(name);
   }
   createText(value: string): Text {
-    return document.createTextNode(value);
+    return this.document.createTextNode(value);
   }
   appendChild(parent: RElement, newChild: Node): void {
     parent.appendChild(newChild);
@@ -588,7 +601,7 @@ class MockRenderer implements Renderer2 {
   }
   selectRootElement(selectorOrNode: string | any): RElement {
     return typeof selectorOrNode === 'string'
-      ? document.querySelector<HTMLElement>(selectorOrNode)!
+      ? this.document.querySelector<HTMLElement>(selectorOrNode)!
       : selectorOrNode;
   }
   parentNode(node: Node): Element | null {
