Skip to content

Commit bd1f129

Browse files
crisbetothePunderWoman
crisbeto
authored and
thePunderWoman
committed
feat(core): support TypeScript 5.7 (#58609)
Updates the repo to allow for TypeScript 5.7 to be used. PR Close #58609
1 parent c56ec5e commit bd1f129

File tree

15 files changed

+857
-44
lines changed

15 files changed

+857
-44
lines changed

‎adev/src/app/features/references/api-items-section/api-items-section.component.spec.ts‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import {By} from '@angular/platform-browser';
1818
describe('ApiItemsSection', () => {
1919
let component: ApiItemsSection;
2020
let fixture: ComponentFixture<ApiItemsSection>;
21-
let apiReferenceManagerSpy: jasmine.SpyObj<ApiReferenceManager>;
2221

2322
const fakeGroup: ApiItemsGroup = {
2423
title: 'Group',
@@ -41,10 +40,7 @@ describe('ApiItemsSection', () => {
4140
beforeEach(() => {
4241
TestBed.configureTestingModule({
4342
imports: [ApiItemsSection],
44-
providers: [
45-
provideRouter([]),
46-
{provide: ApiReferenceManager, useValue: apiReferenceManagerSpy},
47-
],
43+
providers: [provideRouter([])],
4844
});
4945
fixture = TestBed.createComponent(ApiItemsSection);
5046
component = fixture.componentInstance;

‎adev/src/app/features/references/api-reference-list/api-reference-manager.service.spec.ts‎

Lines changed: 0 additions & 33 deletions
This file was deleted.

‎goldens/public-api/common/index.api.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ export const DATE_PIPE_DEFAULT_TIMEZONE: InjectionToken<string>;
127127

128128
// @public
129129
export class DatePipe implements PipeTransform {
130-
constructor(locale: string, defaultTimezone?: (string | null) | undefined, defaultOptions?: (DatePipeConfig | null) | undefined);
130+
constructor(locale: string, defaultTimezone?: string | null | undefined, defaultOptions?: (DatePipeConfig | null) | undefined);
131131
// (undocumented)
132132
transform(value: Date | string | number, format?: string, timezone?: string, locale?: string): string | null;
133133
// (undocumented)

‎integration/typings_test_ts57/BUILD.bazel‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
load("//integration:index.bzl", "ng_integration_test")
2+
3+
ng_integration_test(
4+
name = "test",
5+
# Special case for `typings_test_ts57` test as we want to pin
6+
# `typescript` at version 5.7.x for that test and not link to the
7+
# root @npm//typescript package.
8+
pinned_npm_packages = ["typescript"],
9+
)

‎integration/typings_test_ts57/include-all.ts‎

Lines changed: 67 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
1+
/**
2+
* @license
3+
* Copyright Google LLC All Rights Reserved.
4+
*
5+
* Use of this source code is governed by an MIT-style license that can be
6+
* found in the LICENSE file at https://angular.dev/license
7+
*/
8+
9+
import * as animations from '@angular/animations';
10+
import * as animationsBrowser from '@angular/animations/browser';
11+
import * as animationsBrowserTesting from '@angular/animations/browser/testing';
12+
import * as common from '@angular/common';
13+
import * as commonHttp from '@angular/common/http';
14+
import * as commonTesting from '@angular/common/testing';
15+
import * as commonHttpTesting from '@angular/common/http/testing';
16+
import * as compiler from '@angular/compiler';
17+
import * as core from '@angular/core';
18+
import * as coreTesting from '@angular/core/testing';
19+
import * as elements from '@angular/elements';
20+
import * as forms from '@angular/forms';
21+
import * as localize from '@angular/localize';
22+
import * as platformBrowser from '@angular/platform-browser';
23+
import * as platformBrowserDynamic from '@angular/platform-browser-dynamic';
24+
import * as platformBrowserDynamicTesting from '@angular/platform-browser-dynamic/testing';
25+
import * as platformBrowserAnimations from '@angular/platform-browser/animations';
26+
import * as platformBrowserTesting from '@angular/platform-browser/testing';
27+
import * as platformServer from '@angular/platform-server';
28+
import * as platformServerInit from '@angular/platform-server/init';
29+
import * as platformServerTesting from '@angular/platform-server/testing';
30+
import * as router from '@angular/router';
31+
import * as routerTesting from '@angular/router/testing';
32+
import * as routerUpgrade from '@angular/router/upgrade';
33+
import * as serviceWorker from '@angular/service-worker';
34+
import * as upgrade from '@angular/upgrade';
35+
import * as upgradeStatic from '@angular/upgrade/static';
36+
import * as upgradeTesting from '@angular/upgrade/static/testing';
37+
38+
export default {
39+
animations,
40+
animationsBrowser,
41+
animationsBrowserTesting,
42+
common,
43+
commonTesting,
44+
commonHttp,
45+
commonHttpTesting,
46+
compiler,
47+
core,
48+
coreTesting,
49+
elements,
50+
forms,
51+
localize,
52+
platformBrowser,
53+
platformBrowserTesting,
54+
platformBrowserDynamic,
55+
platformBrowserDynamicTesting,
56+
platformBrowserAnimations,
57+
platformServer,
58+
platformServerInit,
59+
platformServerTesting,
60+
router,
61+
routerTesting,
62+
routerUpgrade,
63+
serviceWorker,
64+
upgrade,
65+
upgradeStatic,
66+
upgradeTesting,
67+
};

‎integration/typings_test_ts57/package.json‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
{
2+
"name": "angular-integration",
3+
"description": "Assert that users with TypeScript 5.7 can type-check an Angular application",
4+
"version": "0.0.0",
5+
"license": "MIT",
6+
"dependencies": {
7+
"@angular/animations": "file:../../dist/packages-dist/animations",
8+
"@angular/common": "file:../../dist/packages-dist/common",
9+
"@angular/compiler": "file:../../dist/packages-dist/compiler",
10+
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
11+
"@angular/core": "file:../../dist/packages-dist/core",
12+
"@angular/elements": "file:../../dist/packages-dist/elements",
13+
"@angular/forms": "file:../../dist/packages-dist/forms",
14+
"@angular/localize": "file:../../dist/packages-dist/localize",
15+
"@angular/platform-browser": "file:../../dist/packages-dist/platform-browser",
16+
"@angular/platform-browser-dynamic": "file:../../dist/packages-dist/platform-browser-dynamic",
17+
"@angular/platform-server": "file:../../dist/packages-dist/platform-server",
18+
"@angular/router": "file:../../dist/packages-dist/router",
19+
"@angular/service-worker": "file:../../dist/packages-dist/service-worker",
20+
"@angular/upgrade": "file:../../dist/packages-dist/upgrade",
21+
"@types/jasmine": "file:../../node_modules/@types/jasmine",
22+
"rxjs": "file:../../node_modules/rxjs",
23+
"typescript": "5.7.2",
24+
"zone.js": "0.14.10"
25+
},
26+
"scripts": {
27+
"test": "tsc"
28+
}
29+
}

‎integration/typings_test_ts57/tsconfig.json‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
{
2+
"compilerOptions": {
3+
"forceConsistentCasingInFileNames": true,
4+
"strict": true,
5+
"noImplicitReturns": true,
6+
"noFallthroughCasesInSwitch": true,
7+
"experimentalDecorators": true,
8+
"module": "commonjs",
9+
"moduleResolution": "node",
10+
"outDir": "./dist/out-tsc",
11+
"rootDir": ".",
12+
"target": "ES2020",
13+
"lib": [
14+
"es5",
15+
"dom",
16+
"es2015.collection",
17+
"es2015.iterable",
18+
"es2015.promise"
19+
],
20+
"types": [],
21+
},
22+
"files": [
23+
"include-all.ts",
24+
"node_modules/@types/jasmine/index.d.ts"
25+
]
26+
}

0 commit comments

Comments
 (0)