fix(forms): _reduceValue arrow function now has correct types. (#44483)

dylhunn · alxhub · commit bce108ab49f9 · 2021-12-15T12:27:06.000-05:00
I previously strengthened some weak types in #44370. One of these fixes exposed an incorrect call into `_reduceChildren` from `_reduceValue`. This was caught in google3 by a caller who was extending `FormGroup` and overriding these methods. Special thanks to Bart G for catching this issue and suggesting a fix. PR Close #44483
diff --git a/packages/forms/src/model.ts b/packages/forms/src/model.ts
@@ -1865,7 +1865,7 @@ export class FormGroup extends AbstractControl {
   /** @internal */
   _reduceValue() {
     return this._reduceChildren(
-        {}, (acc: {[k: string]: AbstractControl}, control: AbstractControl, name: string) => {
+        {}, (acc: {[k: string]: any}, control: AbstractControl, name: string): any => {
           if (control.enabled || this.disabled) {
             acc[name] = control.value;
           }

Original file line number	Diff line number	Diff line change
`@@ -1865,7 +1865,7 @@ export class FormGroup extends AbstractControl {`
`1865`	`1865`	`/** @internal */`
`1866`	`1866`	`_reduceValue() {`
`1867`	`1867`	`return this._reduceChildren(`
`1868`		`- {}, (acc: {[k: string]: AbstractControl}, control: AbstractControl, name: string) => {`
	`1868`	`+ {}, (acc: {[k: string]: any}, control: AbstractControl, name: string): any => {`
`1869`	`1869`	`if (control.enabled \|\| this.disabled) {`
`1870`	`1870`	`acc[name] = control.value;`
`1871`	`1871`	`}`