refactor: ensure modules with 'declare global' are correctly handled by Rollup

alan-agius4 · mattrbeck · commit bb628d8b5080 · 2026-03-12T14:58:00.000-06:00
Explicitly adding an `export {}` to modules containing `declare global` fixes an issue where Rollup would incorrectly claim that the `global` variable is not defined in the emitted `.d.ts` files.

Needed to land the latest `rules_angular`.
diff --git a/packages/core/primitives/event-dispatch/src/earlyeventcontract.ts b/packages/core/primitives/event-dispatch/src/earlyeventcontract.ts
@@ -140,3 +140,6 @@ function removeEventListeners(
     container.removeEventListener(eventTypes[i], earlyEventHandler, /* useCapture */ capture);
   }
 }
+
+// This fixes the RollupError: Exported variable "global" is not defined.
+export {};
diff --git a/packages/core/primitives/event-dispatch/src/event_dispatcher.ts b/packages/core/primitives/event-dispatch/src/event_dispatcher.ts
@@ -190,3 +190,6 @@ export function registerDispatcher(
     dispatcher.dispatch(eventInfo);
   }, Restriction.I_AM_THE_JSACTION_FRAMEWORK);
 }
+
+// This fixes the RollupError: Exported variable "global" is not defined.
+export {};
diff --git a/packages/core/primitives/signals/src/formatter.ts b/packages/core/primitives/signals/src/formatter.ts
@@ -159,3 +159,6 @@ export function installDevToolsSignalFormatter() {
     globalThis.devtoolsFormatters.push(formatter);
   }
 }
+
+// This fixes the RollupError: Exported variable "global" is not defined.
+export {};
diff --git a/packages/core/src/util/ng_dev_mode.ts b/packages/core/src/util/ng_dev_mode.ts
@@ -90,3 +90,6 @@ export function initNgDevMode(): boolean {
   }
   return false;
 }
+
+// This fixes the RollupError: Exported variable "global" is not defined.
+export {};

Original file line number	Diff line number	Diff line change
`@@ -140,3 +140,6 @@ function removeEventListeners(`
`140`	`140`	`container.removeEventListener(eventTypes[i], earlyEventHandler, /* useCapture */ capture);`
`141`	`141`	`}`
`142`	`142`	`}`
	`143`	`+`
	`144`	`+// This fixes the RollupError: Exported variable "global" is not defined.`
	`145`	`+export {};`
Original file line number	Diff line number	Diff line change
`@@ -190,3 +190,6 @@ export function registerDispatcher(`
`190`	`190`	`dispatcher.dispatch(eventInfo);`
`191`	`191`	`}, Restriction.I_AM_THE_JSACTION_FRAMEWORK);`
`192`	`192`	`}`
	`193`	`+`
	`194`	`+// This fixes the RollupError: Exported variable "global" is not defined.`
	`195`	`+export {};`
Original file line number	Diff line number	Diff line change
`@@ -159,3 +159,6 @@ export function installDevToolsSignalFormatter() {`
`159`	`159`	`globalThis.devtoolsFormatters.push(formatter);`
`160`	`160`	`}`
`161`	`161`	`}`
	`162`	`+`
	`163`	`+// This fixes the RollupError: Exported variable "global" is not defined.`
	`164`	`+export {};`
Original file line number	Diff line number	Diff line change
`@@ -90,3 +90,6 @@ export function initNgDevMode(): boolean {`
`90`	`90`	`}`
`91`	`91`	`return false;`
`92`	`92`	`}`
	`93`	`+`
	`94`	`+// This fixes the RollupError: Exported variable "global" is not defined.`
	`95`	`+export {};`