fix(core): avoid repeated work when parsing version (#53598)

crisbeto · thePunderWoman · commit aecb675fa505 · 2023-12-18T16:26:36.000Z
The `Version` class was splitting the same value 3 times instead of doing it once and reusing the result. PR Close #53598
diff --git a/packages/core/src/version.ts b/packages/core/src/version.ts
@@ -17,9 +17,10 @@ export class Version {
   public readonly patch: string;
 
   constructor(public full: string) {
-    this.major = full.split('.')[0];
-    this.minor = full.split('.')[1];
-    this.patch = full.split('.').slice(2).join('.');
+    const parts = full.split('.');
+    this.major = parts[0];
+    this.minor = parts[1];
+    this.patch = parts.slice(2).join('.');
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -17,9 +17,10 @@ export class Version {`
`17`	`17`	`public readonly patch: string;`
`18`	`18`
`19`	`19`	`constructor(public full: string) {`
`20`		`- this.major = full.split('.')[0];`
`21`		`- this.minor = full.split('.')[1];`
`22`		`- this.patch = full.split('.').slice(2).join('.');`
	`20`	`+ const parts = full.split('.');`
	`21`	`+ this.major = parts[0];`
	`22`	`+ this.minor = parts[1];`
	`23`	`+ this.patch = parts.slice(2).join('.');`
`23`	`24`	`}`
`24`	`25`	`}`
`25`	`26`