fix(router): remove setter for injector on OutletContext (#58343)

josephperrott · alxhub · commit a49c35ec7694 · 2024-10-24T16:41:04.000-07:00
This is a cleanup/completion of the work in #56798 PR Close #58343
diff --git a/goldens/public-api/router/index.api.md b/goldens/public-api/router/index.api.md
@@ -542,7 +542,6 @@ export class OutletContext {
     children: ChildrenOutletContexts;
     // (undocumented)
     get injector(): EnvironmentInjector;
-    set injector(_: EnvironmentInjector);
     // (undocumented)
     outlet: RouterOutletContract | null;
     // (undocumented)
diff --git a/packages/router/src/router_outlet_context.ts b/packages/router/src/router_outlet_context.ts
@@ -25,8 +25,6 @@ export class OutletContext {
   get injector(): EnvironmentInjector {
     return getClosestRouteInjector(this.route?.snapshot) ?? this.rootInjector;
   }
-  // TODO(atscott): Only here to avoid a "breaking" change in a patch/minor. Remove in v19.
-  set injector(_: EnvironmentInjector) {}
 
   constructor(private readonly rootInjector: EnvironmentInjector) {
     this.children = new ChildrenOutletContexts(this.rootInjector);

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,6 @@ export class OutletContext {`
`25`	`25`	`get injector(): EnvironmentInjector {`
`26`	`26`	`return getClosestRouteInjector(this.route?.snapshot) ?? this.rootInjector;`
`27`	`27`	`}`
`28`		`- // TODO(atscott): Only here to avoid a "breaking" change in a patch/minor. Remove in v19.`
`29`		`- set injector(_: EnvironmentInjector) {}`
`30`	`28`
`31`	`29`	`constructor(private readonly rootInjector: EnvironmentInjector) {`
`32`	`30`	`this.children = new ChildrenOutletContexts(this.rootInjector);`