fix(language-service): avoid generating TS syntactic diagnostics for templates (#55091)

clydin · atscott · commit a48afe0d9478 · 2024-03-28T12:10:40.000-07:00
Angular's template files are not valid TypeScript. Attempting to get syntactic diagnostics from the underlying TypeScript language service will result in a large amount of false positive errors. Only actual TypeScript files should be analyzed by the underlying TypeScript language service for syntactic errors. PR Close #55091
diff --git a/packages/language-service/src/ts_plugin.ts b/packages/language-service/src/ts_plugin.ts
@@ -22,6 +22,16 @@ export function create(info: ts.server.PluginCreateInfo): NgLanguageService {
 
   const ngLS = new LanguageService(project, tsLS, config);
 
+  function getSyntacticDiagnostics(fileName: string): ts.DiagnosticWithLocation[] {
+    if (!angularOnly && isTypeScriptFile(fileName)) {
+      return tsLS.getSyntacticDiagnostics(fileName);
+    }
+
+    // Template files do not currently produce separate syntactic diagnostics and
+    // are instead produced during the semantic diagnostic analysis.
+    return [];
+  }
+
   function getSemanticDiagnostics(fileName: string): ts.Diagnostic[] {
     const diagnostics: ts.Diagnostic[] = [];
     if (!angularOnly && isTypeScriptFile(fileName)) {
@@ -212,6 +222,7 @@ export function create(info: ts.server.PluginCreateInfo): NgLanguageService {
 
   return {
     ...tsLS,
+    getSyntacticDiagnostics,
     getSemanticDiagnostics,
     getTypeDefinitionAtPosition,
     getQuickInfoAtPosition,
