fix(core): afterNextRender hooks return that callback value. (#57031)

JeanMeche · atscott · commit 9e52c1c8402d · 2024-07-19T13:41:00.000-07:00
`afterRender` was working fine but `afterNextRender` wasn't PR Close #57031
diff --git a/packages/core/src/render3/after_render_hooks.ts b/packages/core/src/render3/after_render_hooks.ts
@@ -613,7 +613,7 @@ function afterRenderImpl(
           if (callbacksLeftToRun < 1) {
             destroy();
           }
-          phaseCallback(...args);
+          return phaseCallback(...args);
         }
       : phaseCallback;
 
diff --git a/packages/core/test/acceptance/after_render_hook_spec.ts b/packages/core/test/acceptance/after_render_hook_spec.ts
@@ -1279,15 +1279,19 @@ describe('after render hooks', () => {
             afterRender({
               earlyRead: () => {
                 log.push('early-read');
+                return 'early';
               },
-              write: () => {
-                log.push('write');
+              write: (previous) => {
+                log.push(`previous was ${previous}, this is write`);
+                return 'write';
               },
-              mixedReadWrite: () => {
-                log.push('mixed-read-write');
+              mixedReadWrite: (previous) => {
+                log.push(`previous was ${previous}, this is mixed-read-write`);
+                return 'mixed';
               },
-              read: () => {
-                log.push('read');
+              read: (previous) => {
+                log.push(`previous was ${previous}, this is read`);
+                return 'read';
               },
             });
           }
@@ -1301,17 +1305,22 @@ describe('after render hooks', () => {
 
         expect(log).toEqual([]);
         TestBed.inject(ApplicationRef).tick();
-        expect(log).toEqual(['early-read', 'write', 'mixed-read-write', 'read']);
+        expect(log).toEqual([
+          'early-read',
+          'previous was early, this is write',
+          'previous was write, this is mixed-read-write',
+          'previous was mixed, this is read',
+        ]);
         TestBed.inject(ApplicationRef).tick();
         expect(log).toEqual([
           'early-read',
-          'write',
-          'mixed-read-write',
-          'read',
+          'previous was early, this is write',
+          'previous was write, this is mixed-read-write',
+          'previous was mixed, this is read',
           'early-read',
-          'write',
-          'mixed-read-write',
-          'read',
+          'previous was early, this is write',
+          'previous was write, this is mixed-read-write',
+          'previous was mixed, this is read',
         ]);
       });
     });

Original file line number	Diff line number	Diff line change
`@@ -613,7 +613,7 @@ function afterRenderImpl(`
`613`	`613`	`if (callbacksLeftToRun < 1) {`
`614`	`614`	`destroy();`
`615`	`615`	`}`
`616`		`- phaseCallback(...args);`
	`616`	`+ return phaseCallback(...args);`
`617`	`617`	`}`
`618`	`618`	`: phaseCallback;`
`619`	`619`