Skip to content

Commit 9cc52b9

Browse files
crisbetoAndrewKushnir
crisbeto
authored and
AndrewKushnir
committed
feat(core): support TypeScript 5.2 (#51334)
Updates the project to support TypeScript 5.2. PR Close #51334
1 parent 0b901a8 commit 9cc52b9

27 files changed

Lines changed: 1096 additions & 43 deletions

File tree

‎.bazelignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,3 +37,4 @@ integration/typings_test_rxjs7/node_modules
3737
integration/typings_test_ts49/node_modules
3838
integration/typings_test_ts50/node_modules
3939
integration/typings_test_ts51/node_modules
40+
integration/typings_test_ts52/node_modules

‎integration/nodenext_resolution/include-all.ts‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,14 @@ import * as animationsBrowser from '@angular/animations/browser';
1313
import * as animationsBrowserTesting from '@angular/animations/browser/testing';
1414
import * as common from '@angular/common';
1515
import * as commonHttp from '@angular/common/http';
16-
import * as commonTesting from '@angular/common/testing';
1716
import * as commonHttpTesting from '@angular/common/http/testing';
17+
import * as commonTesting from '@angular/common/testing';
1818
import * as compiler from '@angular/compiler';
19-
import * as compilerCli from '@angular/compiler-cli';
2019
import * as compilerTesting from '@angular/compiler/testing';
2120
import * as core from '@angular/core';
2221
import * as coreTesting from '@angular/core/testing';
2322
import * as elements from '@angular/elements';
2423
import * as forms from '@angular/forms';
25-
import * as localize from '@angular/localize';
2624
import * as platformBrowser from '@angular/platform-browser';
2725
import * as platformBrowserDynamic from '@angular/platform-browser-dynamic';
2826
import * as platformBrowserDynamicTesting from '@angular/platform-browser-dynamic/testing';
@@ -39,7 +37,14 @@ import * as upgrade from '@angular/upgrade';
3937
import * as upgradeStatic from '@angular/upgrade/static';
4038
import * as upgradeTesting from '@angular/upgrade/static/testing';
4139

40+
// TODO: temporarily disabled until ESM issue is resolved.
41+
// import * as compilerCli from '@angular/compiler-cli';
42+
// import * as localize from '@angular/localize';
43+
4244
export default {
45+
// TODO: temporarily disabled until ESM issue is resolved.
46+
// compilerCli,
47+
// localize,
4348
animations,
4449
animationsBrowser,
4550
animationsBrowserTesting,
@@ -49,12 +54,10 @@ export default {
4954
commonHttpTesting,
5055
compiler,
5156
compilerTesting,
52-
compilerCli,
5357
core,
5458
coreTesting,
5559
elements,
5660
forms,
57-
localize,
5861
platformBrowser,
5962
platformBrowserTesting,
6063
platformBrowserDynamic,

‎integration/nodenext_resolution/package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
"description": "Assert that users with module: nodenext in their tsconfig can import our packages",
44
"version": "0.0.0",
55
"license": "MIT",
6+
"type": "module",
67
"dependencies": {
78
"@angular/animations": "file:../../dist/packages-dist/animations",
89
"@angular/common": "file:../../dist/packages-dist/common",

‎integration/nodenext_resolution/tsconfig.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"noFallthroughCasesInSwitch": true,
77
"experimentalDecorators": true,
88
"module": "NodeNext",
9-
"moduleResolution": "node",
9+
"moduleResolution": "NodeNext",
1010
"outDir": "./dist/out-tsc",
1111
"rootDir": ".",
1212
"target": "es5",

‎integration/typings_test_ts52/BUILD.bazel‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
load("//integration:index.bzl", "ng_integration_test")
2+
3+
ng_integration_test(
4+
name = "test",
5+
# Special case for `typings_test_ts52` test as we want to pin
6+
# `typescript` at version 5.2.x for that test and not link to the
7+
# root @npm//typescript package.
8+
pinned_npm_packages = ["typescript"],
9+
)

‎integration/typings_test_ts52/include-all.ts‎

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
/**
2+
* @license
3+
* Copyright Google LLC All Rights Reserved.
4+
*
5+
* Use of this source code is governed by an MIT-style license that can be
6+
* found in the LICENSE file at https://angular.io/license
7+
*/
8+
9+
10+
11+
import * as animations from '@angular/animations';
12+
import * as animationsBrowser from '@angular/animations/browser';
13+
import * as animationsBrowserTesting from '@angular/animations/browser/testing';
14+
import * as common from '@angular/common';
15+
import * as commonHttp from '@angular/common/http';
16+
import * as commonTesting from '@angular/common/testing';
17+
import * as commonHttpTesting from '@angular/common/http/testing';
18+
import * as compiler from '@angular/compiler';
19+
import * as compilerTesting from '@angular/compiler/testing';
20+
import * as core from '@angular/core';
21+
import * as coreTesting from '@angular/core/testing';
22+
import * as elements from '@angular/elements';
23+
import * as forms from '@angular/forms';
24+
import * as localize from '@angular/localize';
25+
import * as platformBrowser from '@angular/platform-browser';
26+
import * as platformBrowserDynamic from '@angular/platform-browser-dynamic';
27+
import * as platformBrowserDynamicTesting from '@angular/platform-browser-dynamic/testing';
28+
import * as platformBrowserAnimations from '@angular/platform-browser/animations';
29+
import * as platformBrowserTesting from '@angular/platform-browser/testing';
30+
import * as platformServer from '@angular/platform-server';
31+
import * as platformServerInit from '@angular/platform-server/init';
32+
import * as platformServerTesting from '@angular/platform-server/testing';
33+
import * as router from '@angular/router';
34+
import * as routerTesting from '@angular/router/testing';
35+
import * as routerUpgrade from '@angular/router/upgrade';
36+
import * as serviceWorker from '@angular/service-worker';
37+
import * as upgrade from '@angular/upgrade';
38+
import * as upgradeStatic from '@angular/upgrade/static';
39+
import * as upgradeTesting from '@angular/upgrade/static/testing';
40+
41+
export default {
42+
animations,
43+
animationsBrowser,
44+
animationsBrowserTesting,
45+
common,
46+
commonTesting,
47+
commonHttp,
48+
commonHttpTesting,
49+
compiler,
50+
compilerTesting,
51+
core,
52+
coreTesting,
53+
elements,
54+
forms,
55+
localize,
56+
platformBrowser,
57+
platformBrowserTesting,
58+
platformBrowserDynamic,
59+
platformBrowserDynamicTesting,
60+
platformBrowserAnimations,
61+
platformServer,
62+
platformServerInit,
63+
platformServerTesting,
64+
router,
65+
routerTesting,
66+
routerUpgrade,
67+
serviceWorker,
68+
upgrade,
69+
upgradeStatic,
70+
upgradeTesting,
71+
};

‎integration/typings_test_ts52/package.json‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
{
2+
"name": "angular-integration",
3+
"description": "Assert that users with TypeScript 5.2 can type-check an Angular application",
4+
"version": "0.0.0",
5+
"license": "MIT",
6+
"dependencies": {
7+
"@angular/animations": "file:../../dist/packages-dist/animations",
8+
"@angular/common": "file:../../dist/packages-dist/common",
9+
"@angular/compiler": "file:../../dist/packages-dist/compiler",
10+
"@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli",
11+
"@angular/core": "file:../../dist/packages-dist/core",
12+
"@angular/elements": "file:../../dist/packages-dist/elements",
13+
"@angular/forms": "file:../../dist/packages-dist/forms",
14+
"@angular/localize": "file:../../dist/packages-dist/localize",
15+
"@angular/platform-browser": "file:../../dist/packages-dist/platform-browser",
16+
"@angular/platform-browser-dynamic": "file:../../dist/packages-dist/platform-browser-dynamic",
17+
"@angular/platform-server": "file:../../dist/packages-dist/platform-server",
18+
"@angular/router": "file:../../dist/packages-dist/router",
19+
"@angular/service-worker": "file:../../dist/packages-dist/service-worker",
20+
"@angular/upgrade": "file:../../dist/packages-dist/upgrade",
21+
"@types/jasmine": "file:../../node_modules/@types/jasmine",
22+
"rxjs": "file:../../node_modules/rxjs",
23+
"typescript": "5.2.1-rc",
24+
"zone.js": "file:../../dist/zone.js-dist/archive/zone.js.tgz"
25+
},
26+
"scripts": {
27+
"test": "tsc"
28+
}
29+
}

‎integration/typings_test_ts52/tsconfig.json‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
{
2+
"compilerOptions": {
3+
"forceConsistentCasingInFileNames": true,
4+
"strict": true,
5+
"noImplicitReturns": true,
6+
"noFallthroughCasesInSwitch": true,
7+
"experimentalDecorators": true,
8+
"module": "commonjs",
9+
"moduleResolution": "node",
10+
"outDir": "./dist/out-tsc",
11+
"rootDir": ".",
12+
"target": "es5",
13+
"lib": [
14+
"es5",
15+
"dom",
16+
"es2015.collection",
17+
"es2015.iterable",
18+
"es2015.promise"
19+
],
20+
"types": [],
21+
},
22+
"files": [
23+
"include-all.ts",
24+
"node_modules/@types/jasmine/index.d.ts"
25+
]
26+
}

0 commit comments

Comments
 (0)