Revert "fix(compiler-cli): add warning for unused let declarations (#57033)" (#57088)

atscott · atscott · commit 915b0e0b166e · 2024-07-22T15:28:04.000-07:00
This reverts commit c76b440. PR Close #57088
diff --git a/goldens/public-api/compiler-cli/error_code.api.md b/goldens/public-api/compiler-cli/error_code.api.md
@@ -105,7 +105,6 @@ export enum ErrorCode {
     UNDECORATED_PROVIDER = 2005,
     UNINVOKED_FUNCTION_IN_EVENT_BINDING = 8111,
     UNSUPPORTED_INITIALIZER_API_USAGE = 8110,
-    UNUSED_LET_DECLARATION = 8112,
     // (undocumented)
     VALUE_HAS_WRONG_TYPE = 1010,
     // (undocumented)
diff --git a/goldens/public-api/compiler-cli/extended_template_diagnostic_name.api.md b/goldens/public-api/compiler-cli/extended_template_diagnostic_name.api.md
@@ -27,9 +27,7 @@ export enum ExtendedTemplateDiagnosticName {
     // (undocumented)
     TEXT_ATTRIBUTE_NOT_BINDING = "textAttributeNotBinding",
     // (undocumented)
-    UNINVOKED_FUNCTION_IN_EVENT_BINDING = "uninvokedFunctionInEventBinding",
-    // (undocumented)
-    UNUSED_LET_DECLARATION = "unusedLetDeclaration"
+    UNINVOKED_FUNCTION_IN_EVENT_BINDING = "uninvokedFunctionInEventBinding"
 }
 
 // (No @packageDocumentation comment for this package)
diff --git a/packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts b/packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts
@@ -495,19 +495,6 @@ export enum ErrorCode {
    */
   UNINVOKED_FUNCTION_IN_EVENT_BINDING = 8111,
 
-  /**
-   * A `@let` declaration in a template isn't used.
-   *
-   * For example:
-   * ```
-   * @let used = 1; <!-- Not an error -->
-   * @let notUsed = 2; <!-- Error -->
-   *
-   * {{used}}
-   * ```
-   */
-  UNUSED_LET_DECLARATION = 8112,
-
   /**
    * The template type-checking engine would need to generate an inline type check block for a
    * component, but the current type-checking environment doesn't support it.
diff --git a/packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.ts b/packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.ts
@@ -27,5 +27,4 @@ export enum ExtendedTemplateDiagnosticName {
   SKIP_HYDRATION_NOT_STATIC = 'skipHydrationNotStatic',
   INTERPOLATED_SIGNAL_NOT_INVOKED = 'interpolatedSignalNotInvoked',
   CONTROL_FLOW_PREVENTING_CONTENT_PROJECTION = 'controlFlowPreventingContentProjection',
-  UNUSED_LET_DECLARATION = 'unusedLetDeclaration',
 }
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazel b/packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazel
@@ -22,7 +22,6 @@ ts_library(
         "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/suffix_not_supported",
         "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/text_attribute_not_binding",
         "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding",
-        "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/unused_let_declaration",
         "@npm//typescript",
     ],
 )
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/unused_let_declaration/BUILD.bazel b/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/unused_let_declaration/BUILD.bazel
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/unused_let_declaration/index.ts b/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/unused_let_declaration/index.ts
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/extended/index.ts b/packages/compiler-cli/src/ngtsc/typecheck/extended/index.ts
@@ -18,7 +18,6 @@ import {factory as optionalChainNotNullableFactory} from './checks/optional_chai
 import {factory as suffixNotSupportedFactory} from './checks/suffix_not_supported';
 import {factory as textAttributeNotBindingFactory} from './checks/text_attribute_not_binding';
 import {factory as uninvokedFunctionInEventBindingFactory} from './checks/uninvoked_function_in_event_binding';
-import {factory as unusedLetDeclarationFactory} from './checks/unused_let_declaration';
 
 export {ExtendedTemplateCheckerImpl} from './src/extended_template_checker';
 
@@ -35,7 +34,6 @@ export const ALL_DIAGNOSTIC_FACTORIES: readonly TemplateCheckFactory<
   suffixNotSupportedFactory,
   interpolatedSignalNotInvoked,
   uninvokedFunctionInEventBindingFactory,
-  unusedLetDeclarationFactory,
 ];
 
 export const SUPPORTED_DIAGNOSTIC_NAMES = new Set<string>([
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/unused_let_declaration/BUILD.bazel b/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/unused_let_declaration/BUILD.bazel
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/unused_let_declaration/unused_let_declaration_spec.ts b/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/unused_let_declaration/unused_let_declaration_spec.ts
diff --git a/packages/compiler-cli/test/ngtsc/template_typecheck_spec.ts b/packages/compiler-cli/test/ngtsc/template_typecheck_spec.ts
@@ -6611,18 +6611,7 @@ suppress
     });
 
     describe('@let declarations', () => {
-      beforeEach(() =>
-        env.tsconfig({
-          strictTemplates: true,
-          extendedDiagnostics: {
-            checks: {
-              // Suppress the diagnostic for unused @let since some of the error cases
-              // we're checking for here also qualify as being unused which adds noise.
-              unusedLetDeclaration: 'suppress',
-            },
-          },
-        }),
-      );
+      beforeEach(() => env.tsconfig({strictTemplates: true}));
 
       it('should infer the type of a let declaration', () => {
         env.write(
diff --git a/packages/language-service/test/quick_info_spec.ts b/packages/language-service/test/quick_info_spec.ts
@@ -708,7 +708,7 @@ describe('quick info', () => {
     describe('let declarations', () => {
       it('should get quick info for a let declaration', () => {
         expectQuickInfo({
-          templateOverride: `@let na¦me = 'Frodo'; {{name}}`,
+          templateOverride: `@let na¦me = 'Frodo';`,
           expectedSpanText: `@let name = 'Frodo'`,
           expectedDisplayString: `(let) name: "Frodo"`,
         });

Original file line number	Diff line number	Diff line change
`@@ -27,5 +27,4 @@ export enum ExtendedTemplateDiagnosticName {`
`27`	`27`	`SKIP_HYDRATION_NOT_STATIC = 'skipHydrationNotStatic',`
`28`	`28`	`INTERPOLATED_SIGNAL_NOT_INVOKED = 'interpolatedSignalNotInvoked',`
`29`	`29`	`CONTROL_FLOW_PREVENTING_CONTENT_PROJECTION = 'controlFlowPreventingContentProjection',`
`30`		`- UNUSED_LET_DECLARATION = 'unusedLetDeclaration',`
`31`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@ ts_library(`
`22`	`22`	`"//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/suffix_not_supported",`
`23`	`23`	`"//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/text_attribute_not_binding",`
`24`	`24`	`"//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_event_binding",`
`25`		`- "//packages/compiler-cli/src/ngtsc/typecheck/extended/checks/unused_let_declaration",`
`26`	`25`	`"@npm//typescript",`
`27`	`26`	`],`
`28`	`27`	`)`