refactor(core): Reorder resolve/reject in relation to navigate[error/success] (#63377)

atscott · AndrewKushnir · commit 8e4b7e47f4b4 · 2025-08-27T11:16:53.000-07:00
Order was changed in whatwg/html#11512 (see that PR for details as to why). https://whatpr.org/html/10919/nav-history-apis.html#abort-a-navigateevent PR Close #63377
diff --git a/packages/core/primitives/dom-navigation/testing/fake_navigation.ts b/packages/core/primitives/dom-navigation/testing/fake_navigation.ts
@@ -963,12 +963,12 @@ function dispatchNavigateEvent({
         }
         navigation.navigateEvent = null;
         finishNavigationEvent(event, true);
+        result.finishedResolve();
         const navigatesuccessEvent = new Event('navigatesuccess', {
           bubbles: false,
           cancelable: false,
         });
         navigation.eventTarget.dispatchEvent(navigatesuccessEvent);
-        result.finishedResolve();
         (navigation.transition as InternalNavigationTransition)?.finishedResolve();
         navigation.transition = null;
       })
@@ -996,16 +996,14 @@ function dispatchNavigateEvent({
     } else if (this.interceptionState === 'intercepted') {
       this.interceptionState = 'finished';
     }
+    result.committedReject(reason);
+    result.finishedReject(reason);
     const navigateerrorEvent = new Event('navigateerror', {
       bubbles: false,
       cancelable,
     }) as ErrorEvent;
     (navigateerrorEvent as unknown as {error: Error}).error = reason;
     navigation.eventTarget.dispatchEvent(navigateerrorEvent);
-    if (result.committedTo === null && !result.signal.aborted) {
-      result.committedReject(reason);
-    }
-    result.finishedReject(reason);
     const transition = navigation.transition as InternalNavigationTransition | undefined;
     transition?.committedReject(reason);
     transition?.finishedReject(reason);
