fix(compiler): fix detection of directive deps in JIT (#62666)

JeanMeche · NothingEverHappens · commit 8ad10fd63b01 · 2025-07-17T14:20:32.000-04:00
This fix also matches the implementation to the jsdoc for `hasDirectiveDependencies` "Whether any of the component's dependencies are directives" fixes #62573 PR Close #62666
diff --git a/packages/compiler/src/jit_compiler_facade.ts b/packages/compiler/src/jit_compiler_facade.ts
@@ -657,7 +657,7 @@ function convertDeclareComponentFacadeToMetadata(
     decl.pipes && declarations.push(...convertPipeMapToMetadata(decl.pipes));
   }
 
-  const hasDirectiveDependencies = declarations.every(
+  const hasDirectiveDependencies = declarations.some(
     ({kind}) =>
       kind === R3TemplateDependencyKind.Directive || kind === R3TemplateDependencyKind.NgModule,
   );
diff --git a/packages/core/test/render3/jit/declare_component_spec.ts b/packages/core/test/render3/jit/declare_component_spec.ts
@@ -387,6 +387,35 @@ describe('component declaration jit compilation', () => {
     });
   });
 
+  it('should bind directive inputs as regular property (not DOM property) in the presence of pipes', () => {
+    // https://github.com/angular/angular/issues/62573
+    const def = ɵɵngDeclareComponent({
+      version: '18.0.0',
+      type: TestClass,
+      isStandalone: true,
+      dependencies: [
+        {
+          kind: 'directive',
+          type: TestDir,
+          selector: '[dir]',
+          inputs: ['dir'],
+        },
+        {
+          kind: 'pipe',
+          type: TestPipe,
+          name: 'test',
+        },
+      ],
+      template: `<div [dir]="'test' | test"></div>`,
+    }) as ComponentDef<TestClass>;
+
+    expectComponentDef(def, {
+      template: functionContaining([/property[^(]*\('dir',/]),
+      directives: [TestDir],
+      pipes: [TestPipe],
+    });
+  });
+
   it('should compile used components', () => {
     const def = ɵɵngDeclareComponent({
       version: '18.0.0',

Original file line number	Diff line number	Diff line change
`@@ -657,7 +657,7 @@ function convertDeclareComponentFacadeToMetadata(`
`657`	`657`	`decl.pipes && declarations.push(...convertPipeMapToMetadata(decl.pipes));`
`658`	`658`	`}`
`659`	`659`
`660`		`- const hasDirectiveDependencies = declarations.every(`
	`660`	`+ const hasDirectiveDependencies = declarations.some(`
`661`	`661`	`({kind}) =>`
`662`	`662`	`kind === R3TemplateDependencyKind.Directive \|\| kind === R3TemplateDependencyKind.NgModule,`
`663`	`663`	`);`