fix(core): tree shake version class (#53598)

crisbeto · thePunderWoman · commit 872e7f25fea8 · 2023-12-18T16:26:36.000Z
Core bundles were retaining the `Version` class and `VERSION` constant, because we stamp out the current version in the DOM. This shouldn't be necessary, because any usage of `0.0.0-PLACEHOLDER` will be replaced with the current version at build time. These changes remove the reference so it can be tree shaken away. PR Close #53598
diff --git a/packages/core/src/render3/component_ref.ts b/packages/core/src/render3/component_ref.ts
@@ -23,7 +23,6 @@ import {NgModuleRef} from '../linker/ng_module_factory';
 import {Renderer2, RendererFactory2} from '../render/api';
 import {Sanitizer} from '../sanitization/sanitizer';
 import {assertDefined, assertGreaterThan, assertIndexInRange} from '../util/assert';
-import {VERSION} from '../version';
 import {NOT_FOUND_CHECK_ONLY_ELEMENT_INJECTOR} from '../view/provider_flags';
 
 import {AfterRenderEventManager} from './after_render_hooks';
@@ -501,7 +500,8 @@ function setRootNodeAttributes(
     hostRenderer: Renderer2, componentDef: ComponentDef<unknown>, hostRNode: RElement,
     rootSelectorOrNode: any) {
   if (rootSelectorOrNode) {
-    setUpAttributes(hostRenderer, hostRNode, ['ng-version', VERSION.full]);
+    // The placeholder will be replaced with the actual version at build time.
+    setUpAttributes(hostRenderer, hostRNode, ['ng-version', '0.0.0-PLACEHOLDER']);
   } else {
     // If host element is created as a part of this function call (i.e. `rootSelectorOrNode`
     // is not defined), also apply attributes and classes extracted from component selector.
diff --git a/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json b/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
@@ -503,9 +503,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/animations/bundle.golden_symbols.json b/packages/core/test/bundling/animations/bundle.golden_symbols.json
@@ -560,9 +560,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
@@ -416,9 +416,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/defer/bundle.golden_symbols.json b/packages/core/test/bundling/defer/bundle.golden_symbols.json
@@ -461,9 +461,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "VIEW_REFS"
   },
diff --git a/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json b/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
@@ -560,9 +560,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "VE_ViewContainerRef"
   },
diff --git a/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json b/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
@@ -554,9 +554,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "VE_ViewContainerRef"
   },
diff --git a/packages/core/test/bundling/hello_world/bundle.golden_symbols.json b/packages/core/test/bundling/hello_world/bundle.golden_symbols.json
@@ -308,9 +308,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/hydration/bundle.golden_symbols.json b/packages/core/test/bundling/hydration/bundle.golden_symbols.json
@@ -461,9 +461,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -707,9 +707,6 @@
   {
     "name": "UrlTree"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "VE_ViewContainerRef"
   },
diff --git a/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json b/packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json
@@ -365,9 +365,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "ViewEncapsulation"
   },
diff --git a/packages/core/test/bundling/todo/bundle.golden_symbols.json b/packages/core/test/bundling/todo/bundle.golden_symbols.json
@@ -479,9 +479,6 @@
   {
     "name": "UnsubscriptionError"
   },
-  {
-    "name": "VERSION"
-  },
   {
     "name": "VE_ViewContainerRef"
   },

Original file line number	Diff line number	Diff line change
`@@ -503,9 +503,6 @@`
`503`	`503`	`{`
`504`	`504`	`"name": "UnsubscriptionError"`
`505`	`505`	`},`
`506`		`- {`
`507`		`- "name": "VERSION"`
`508`		`- },`
`509`	`506`	`{`
`510`	`507`	`"name": "ViewEncapsulation"`
`511`	`508`	`},`
Original file line number	Diff line number	Diff line change
`@@ -560,9 +560,6 @@`
`560`	`560`	`{`
`561`	`561`	`"name": "UnsubscriptionError"`
`562`	`562`	`},`
`563`		`- {`
`564`		`- "name": "VERSION"`
`565`		`- },`
`566`	`563`	`{`
`567`	`564`	`"name": "ViewEncapsulation"`
`568`	`565`	`},`
Original file line number	Diff line number	Diff line change
`@@ -416,9 +416,6 @@`
`416`	`416`	`{`
`417`	`417`	`"name": "UnsubscriptionError"`
`418`	`418`	`},`
`419`		`- {`
`420`		`- "name": "VERSION"`
`421`		`- },`
`422`	`419`	`{`
`423`	`420`	`"name": "ViewEncapsulation"`
`424`	`421`	`},`
Original file line number	Diff line number	Diff line change
`@@ -461,9 +461,6 @@`
`461`	`461`	`{`
`462`	`462`	`"name": "UnsubscriptionError"`
`463`	`463`	`},`
`464`		`- {`
`465`		`- "name": "VERSION"`
`466`		`- },`
`467`	`464`	`{`
`468`	`465`	`"name": "VIEW_REFS"`
`469`	`466`	`},`
Original file line number	Diff line number	Diff line change
`@@ -554,9 +554,6 @@`
`554`	`554`	`{`
`555`	`555`	`"name": "UnsubscriptionError"`
`556`	`556`	`},`
`557`		`- {`
`558`		`- "name": "VERSION"`
`559`		`- },`
`560`	`557`	`{`
`561`	`558`	`"name": "VE_ViewContainerRef"`
`562`	`559`	`},`
Original file line number	Diff line number	Diff line change
`@@ -308,9 +308,6 @@`
`308`	`308`	`{`
`309`	`309`	`"name": "UnsubscriptionError"`
`310`	`310`	`},`
`311`		`- {`
`312`		`- "name": "VERSION"`
`313`		`- },`
`314`	`311`	`{`
`315`	`312`	`"name": "ViewEncapsulation"`
`316`	`313`	`},`
Original file line number	Diff line number	Diff line change
`@@ -707,9 +707,6 @@`
`707`	`707`	`{`
`708`	`708`	`"name": "UrlTree"`
`709`	`709`	`},`
`710`		`- {`
`711`		`- "name": "VERSION"`
`712`		`- },`
`713`	`710`	`{`
`714`	`711`	`"name": "VE_ViewContainerRef"`
`715`	`712`	`},`