Skip to content

Commit 86c5e34

Browse files
devversionthePunderWoman
authored andcommitted
fix(common): remove code duplication between entry-points (#51500)
The common packages were duplicating a little bit of code due to relative imports between entry-points. This caused bundlers to inline shared functions twice in both FESM outputs.i PR Close #51500
1 parent 698c058 commit 86c5e34

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

packages/common/src/common.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,4 @@ export {VERSION} from './version';
2828
export {ViewportScroller, NullViewportScroller as ɵNullViewportScroller} from './viewport_scroller';
2929
export {XhrFactory} from './xhr';
3030
export {IMAGE_CONFIG, ImageConfig, IMAGE_LOADER, ImageLoader, ImageLoaderConfig, NgOptimizedImage, PRECONNECT_CHECK_BLOCKLIST, provideCloudflareLoader, provideCloudinaryLoader, provideImageKitLoader, provideImgixLoader} from './directives/ng_optimized_image';
31+
export {normalizeQueryParams as ɵnormalizeQueryParams} from './location/util';

packages/common/testing/src/location_mock.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@
66
* found in the LICENSE file at https://angular.io/license
77
*/
88

9-
import {Location, LocationStrategy} from '@angular/common';
9+
import {Location, LocationStrategy, ɵnormalizeQueryParams as normalizeQueryParams} from '@angular/common';
1010
import {EventEmitter, Injectable} from '@angular/core';
1111
import {SubscriptionLike} from 'rxjs';
1212

13-
import {normalizeQueryParams} from '../../src/location/util';
14-
1513
/**
1614
* A spy for {@link Location} that allows tests to fire simulated location events.
1715
*

0 commit comments

Comments
 (0)