feat(core): Stabilize PendingTasks Injectable (#60716)

atscott · atscott · commit 866cea9a057a · 2025-04-03T10:11:15.000-07:00
This PR marks `PendingTasks` as stable, though the `run` function remains in dev preview. There are still questions around its return value, error handling, and whether it will be replaced by a different `task` API that would better track context through the injector/injection context. PR Close #60716
diff --git a/goldens/public-api/core/index.api.md b/goldens/public-api/core/index.api.md
@@ -1391,7 +1391,7 @@ export const PACKAGE_ROOT_URL: InjectionToken<string>;
 // @public
 export class PendingTasks {
     add(): () => void;
-    run<T>(fn: () => Promise<T>): void;
+    run(fn: () => Promise<unknown>): void;
     // (undocumented)
     static ɵprov: unknown;
 }
diff --git a/packages/core/src/pending_tasks.ts b/packages/core/src/pending_tasks.ts
@@ -111,7 +111,6 @@ export class PendingTasksInternal implements OnDestroy {
  * ```
  *
  * @publicApi
- * @developerPreview
  */
 export class PendingTasks {
   private readonly internalPendingTasks = inject(PendingTasksInternal);
@@ -145,8 +144,9 @@ export class PendingTasks {
    * ```
    *
    * @param fn The asynchronous function to execute
+   * @developerPreview
    */
-  run<T>(fn: () => Promise<T>): void {
+  run(fn: () => Promise<unknown>): void {
     const removeTask = this.add();
     fn().catch(this.errorHandler).finally(removeTask);
   }

Original file line number	Diff line number	Diff line change
`@@ -1391,7 +1391,7 @@ export const PACKAGE_ROOT_URL: InjectionToken<string>;`
`1391`	`1391`	`// @public`
`1392`	`1392`	`export class PendingTasks {`
`1393`	`1393`	`add(): () => void;`
`1394`		`- run<T>(fn: () => Promise<T>): void;`
	`1394`	`+ run(fn: () => Promise<unknown>): void;`
`1395`	`1395`	`// (undocumented)`
`1396`	`1396`	`static ɵprov: unknown;`
`1397`	`1397`	`}`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,6 @@ export class PendingTasksInternal implements OnDestroy {`
`111`	`111`	* ```
`112`	`112`	`*`
`113`	`113`	`* @publicApi`
`114`		`- * @developerPreview`
`115`	`114`	`*/`
`116`	`115`	`export class PendingTasks {`
`117`	`116`	`private readonly internalPendingTasks = inject(PendingTasksInternal);`
`@@ -145,8 +144,9 @@ export class PendingTasks {`
`145`	`144`	* ```
`146`	`145`	`*`
`147`	`146`	`* @param fn The asynchronous function to execute`
	`147`	`+ * @developerPreview`
`148`	`148`	`*/`
`149`		`- run<T>(fn: () => Promise<T>): void {`
	`149`	`+ run(fn: () => Promise<unknown>): void {`
`150`	`150`	`const removeTask = this.add();`
`151`	`151`	`fn().catch(this.errorHandler).finally(removeTask);`
`152`	`152`	`}`