Skip to content

Commit 83a6e20

Browse files
AndrewKushniralxhub
AndrewKushnir
authored and
alxhub
committed
refactor(compiler): drop obsolete NgFactory and NgSummary config options (#48268)
The options to generate NgFactory and NgSummary files were added to Ivy for backwards compatibility with ViewEngine. Since ViewEngine was deprecated and removed, the NgFactory and NgSummary files are no longer used as well. This commit drops obsolete options to generate NgFactory and NgSummary files. Also, the logic that generates those files is also removed. PR Close #48268
1 parent f9b6a3f commit 83a6e20

File tree

50 files changed

+23
-1178
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+23
-1178
lines changed

‎devtools/tools/ng_module.bzl‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ def ng_module(name, tsconfig = "//devtools:tsconfig.json", srcs = [], angular_as
44
_ng_module(
55
name = name,
66
tsconfig = tsconfig,
7-
generate_ve_shims = False,
87
srcs = srcs,
98
assets = angular_assets,
109
**kwargs

‎goldens/public-api/compiler-cli/compiler_options.md‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,6 @@ export interface MiscOptions {
5656
disableTypeScriptVersionCheck?: boolean;
5757
}
5858

59-
// @public
60-
export interface NgcCompatibilityOptions {
61-
generateNgFactoryShims?: boolean;
62-
generateNgSummaryShims?: boolean;
63-
}
64-
6559
// @public
6660
export interface StrictTemplateOptions {
6761
strictAttributeTypes?: boolean;

‎integration/.gitignore‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,5 @@ tmp/
55
*/src/*.d.ts
66
*/src/*.js
77
!karma.conf.js
8-
**/*.ngfactory.ts
9-
**/*.ngsummary.json
10-
**/*.ngsummary.ts
118
**/.yarn_local_cache*
129
**/NPM_PACKAGE_MANIFEST.json

‎modules/benchmarks/src/change_detection/transplanted_views/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ package(default_visibility = ["//modules/benchmarks:__subpackages__"])
77
ng_module(
88
name = "transplanted_views_lib",
99
srcs = glob(["*.ts"]),
10-
generate_ve_shims = True,
1110
tsconfig = "//modules/benchmarks:tsconfig-build.json",
1211
deps = [
1312
"//modules/benchmarks/src:util_lib",

‎modules/benchmarks/src/expanding_rows/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ ng_module(
99
["**/*.ts"],
1010
exclude = ["**/*.perf-spec.ts"],
1111
),
12-
generate_ve_shims = True,
1312
deps = [
1413
"//packages:types",
1514
"//packages/common",

‎modules/benchmarks/src/js-web-frameworks/ng2/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ package(default_visibility = ["//modules/benchmarks:__subpackages__"])
66
ng_module(
77
name = "ng2",
88
srcs = glob(["*.ts"]),
9-
generate_ve_shims = True,
109
tsconfig = "//modules/benchmarks:tsconfig-build.json",
1110
deps = [
1211
"//modules/benchmarks/src:util_lib",

‎modules/benchmarks/src/largeform/ng2/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ package(default_visibility = ["//modules/benchmarks:__subpackages__"])
99
ng_module(
1010
name = "ng2",
1111
srcs = glob(["*.ts"]),
12-
generate_ve_shims = True,
1312
tsconfig = "//modules/benchmarks:tsconfig-build.json",
1413
deps = [
1514
"//modules/benchmarks/src:util_lib",

‎modules/benchmarks/src/largetable/ng2/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ package(default_visibility = ["//modules/benchmarks:__subpackages__"])
1010
ng_module(
1111
name = "ng2",
1212
srcs = glob(["*.ts"]),
13-
generate_ve_shims = True,
1413
tsconfig = "//modules/benchmarks:tsconfig-build.json",
1514
deps = [
1615
"//modules/benchmarks/src:util_lib",

‎modules/benchmarks/src/largetable/ng2_switch/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ package(default_visibility = ["//modules/benchmarks:__subpackages__"])
77
ng_module(
88
name = "ng2_switch",
99
srcs = glob(["*.ts"]),
10-
generate_ve_shims = True,
1110
tsconfig = "//modules/benchmarks:tsconfig-build.json",
1211
deps = [
1312
"//modules/benchmarks/src:util_lib",

‎modules/benchmarks/src/styling/ng2/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ package(default_visibility = ["//modules/benchmarks:__subpackages__"])
66
ng_module(
77
name = "ng2",
88
srcs = glob(["*.ts"]),
9-
generate_ve_shims = True,
109
tsconfig = "//modules/benchmarks:tsconfig-build.json",
1110
deps = [
1211
"//modules/benchmarks/src:util_lib",

0 commit comments

Comments
 (0)