fix(language-service): correct incomplete escaping (#51557)

josephperrott · thePunderWoman · commit 8081fdd22d68 · 2023-08-29T19:48:25.000Z
Correct incomplete escaping and replace all instances of $ PR Close #51557
diff --git a/packages/language-service/src/utils.ts b/packages/language-service/src/utils.ts
@@ -179,7 +179,7 @@ function toAttributeCssSelector(attribute: t.TextAttribute|t.BoundAttribute|t.Bo
   // Any dollar signs that appear in the attribute name and/or value need to be escaped because they
   // need to be taken as literal characters rather than special selector behavior of dollar signs in
   // CSS.
-  return selector.replace('$', '\\$');
+  return selector.replace(/\$/g, '\\$');
 }
 
 function getNodeName(node: t.Template|t.Element): string {

Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ function toAttributeCssSelector(attribute: t.TextAttribute\|t.BoundAttribute\|t.Bo`
`179`	`179`	`// Any dollar signs that appear in the attribute name and/or value need to be escaped because they`
`180`	`180`	`// need to be taken as literal characters rather than special selector behavior of dollar signs in`
`181`	`181`	`// CSS.`
`182`		`- return selector.replace('$', '\\$');`
	`182`	`+ return selector.replace(/\$/g, '\\$');`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`function getNodeName(node: t.Template\|t.Element): string {`