fixup! fix(ivy): handle class declarations consistently in ES5 code

gkalpak · gkalpak · commit 7ba59e1fa001 · 2019-03-21T19:53:25.000+02:00
diff --git a/packages/compiler-cli/ngcc/src/host/esm2015_host.ts b/packages/compiler-cli/ngcc/src/host/esm2015_host.ts
@@ -446,10 +446,7 @@ export class Esm2015ReflectionHost extends TypeScriptReflectionHost implements N
   /**
    * Examine a symbol which should be of a class, and return metadata about its members.
    *
-   * @param symbol the `ClassSymbol` representing the class over which to reflect. If the source is
-   * in
-   * ES2015 format, this will be a `ts.ClassDeclaration` node. If the source is in ES5 format, this
-   * might be a `ts.FunctionDeclaration` as classes in ES5 are downleveled to constructor functions.
+   * @param symbol the `ClassSymbol` representing the class over which to reflect.
    * @returns an array of `ClassMember` metadata representing the members of the class.
    */
   protected getMembersOfSymbol(symbol: ClassSymbol): ClassMember[] {
diff --git a/packages/compiler-cli/ngcc/src/host/esm5_host.ts b/packages/compiler-cli/ngcc/src/host/esm5_host.ts
@@ -68,13 +68,13 @@ export class Esm5ReflectionHost extends Esm2015ReflectionHost {
    * So we might need to dig around to get hold of the "class" declaration.
    *
    * `node` might be one of:
-   * - A class declaration (from a declaration file).
+   * - A class declaration (from a typings file).
    * - The declaration of the outer variable, which is assigned the result of the IIFE.
    * - The function declaration inside the IIFE, which is eventually returned and assigned to the
    *   outer variable.
    *
-   * The returned declaration is either the class declaration (from the declaration file) or the
-   * outer variable declaration.
+   * The returned declaration is either the class declaration (from the typings file) or the outer
+   * variable declaration.
    *
    * @param node the node that represents the class whose declaration we are finding.
    * @returns the declaration of the class or `undefined` if it is not a "class".

Original file line number	Diff line number	Diff line change
`@@ -68,13 +68,13 @@ export class Esm5ReflectionHost extends Esm2015ReflectionHost {`
`68`	`68`	`* So we might need to dig around to get hold of the "class" declaration.`
`69`	`69`	`*`
`70`	`70`	* `node` might be one of:
`71`		`- * - A class declaration (from a declaration file).`
	`71`	`+ * - A class declaration (from a typings file).`
`72`	`72`	`* - The declaration of the outer variable, which is assigned the result of the IIFE.`
`73`	`73`	`* - The function declaration inside the IIFE, which is eventually returned and assigned to the`
`74`	`74`	`* outer variable.`
`75`	`75`	`*`
`76`		`- * The returned declaration is either the class declaration (from the declaration file) or the`
`77`		`- * outer variable declaration.`
	`76`	`+ * The returned declaration is either the class declaration (from the typings file) or the outer`
	`77`	`+ * variable declaration.`
`78`	`78`	`*`
`79`	`79`	`* @param node the node that represents the class whose declaration we are finding.`
`80`	`80`	* @returns the declaration of the class or `undefined` if it is not a "class".