fix(core): Ensure errors in listeners report to the application error handler (#60251)

atscott · thePunderWoman · commit 7b819be83fc3 · 2025-04-01T17:03:08.000Z
Practically speaking, this change ensures that Angular is able to make decisions about what to do when an uncaught error happens. For tests, this will mean that, by default, the error either causes the `fixture.whenStable` promise to reject if there is one or rethrow the error. This ensures tests do not accidentally ignore errors. Opting out of this can be done with the `rethrowApplicationErrors: false` option in `TestBed`. For SSR, there may be additional behaviors in the future that we want to add, such as redirecting to an error page or responding with a 500 status code. BREAKING CHANGE: Uncaught errors in listeners which were previously only reported to `ErrorHandler` are now also reported to Angular's internal error handling machinery. For tests, this means that the error will be rethrown by default rather than only logging the error. Developers should fix these errors, catch them in the test if the test is intentionally covering an error case, or use `rethrowApplicationErrors: false` in `configureTestingModule` as a last resort. PR Close #60251
diff --git a/packages/core/src/render3/view/listeners.ts b/packages/core/src/render3/view/listeners.ts
@@ -21,11 +21,11 @@ import {
 } from '../util/view_utils';
 import {profiler} from '../profiler';
 import {ProfilerEvent} from '../profiler_types';
-import {ErrorHandler} from '../../error_handler';
 import {markViewDirty} from '../instructions/mark_view_dirty';
 import {RElement, RNode} from '../interfaces/renderer_dom';
 import {GlobalTargetResolver, Renderer} from '../interfaces/renderer';
 import {assertNotSame} from '../../util/assert';
+import {handleUncaughtError} from '../instructions/shared';
 
 /** Shorthand for an event listener callback function to reduce duplication. */
 export type EventCallback = (event?: any) => any;
@@ -95,27 +95,14 @@ function executeListenerWithErrorHandling(
     // Only explicitly returning false from a listener should preventDefault
     return listenerFn(e) !== false;
   } catch (error) {
-    // TODO(atscott): This should report to the application error handler, not the ErrorHandler on LView injector
-    handleError(lView, error);
+    handleUncaughtError(lView, error);
     return false;
   } finally {
     profiler(ProfilerEvent.OutputEnd, context, listenerFn);
     setActiveConsumer(prevConsumer);
   }
 }
 
-/**
- * Handles an error thrown in an LView.
- * @deprecated Use handleUncaughtError to report to application error handler
- */
-function handleError(lView: LView, error: any): void {
-  const injector = lView[INJECTOR];
-  if (!injector) {
-    return;
-  }
-  injector.get(ErrorHandler, null)?.handleError(error);
-}
-
 /**
  * Listen to a DOM event on a specific node.
  * @param tNode TNode on which to listen.
diff --git a/packages/core/test/acceptance/create_component_spec.ts b/packages/core/test/acceptance/create_component_spec.ts
@@ -1173,6 +1173,7 @@ describe('createComponent', () => {
       }
 
       TestBed.configureTestingModule({
+        rethrowApplicationErrors: false,
         providers: [
           {
             provide: ErrorHandler,
diff --git a/packages/core/test/acceptance/listener_spec.ts b/packages/core/test/acceptance/listener_spec.ts
@@ -440,6 +440,7 @@ describe('event listeners', () => {
       }
 
       TestBed.configureTestingModule({
+        rethrowApplicationErrors: false,
         declarations: [TestCmpt, LikesClicks, ThrowsOnClicks],
         providers: [{provide: ErrorHandler, useClass: CountingErrorHandler}],
       });
diff --git a/packages/core/test/acceptance/profiler_spec.ts b/packages/core/test/acceptance/profiler_spec.ts
@@ -175,6 +175,7 @@ describe('profiler', () => {
       const errorSpy = spyOn(handler, 'handleError');
 
       TestBed.configureTestingModule({
+        rethrowApplicationErrors: false,
         declarations: [MyComponent],
         providers: [{provide: ErrorHandler, useValue: handler}],
       });

Original file line number	Diff line number	Diff line change
`@@ -1173,6 +1173,7 @@ describe('createComponent', () => {`
`1173`	`1173`	`}`
`1174`	`1174`
`1175`	`1175`	`TestBed.configureTestingModule({`
	`1176`	`+ rethrowApplicationErrors: false,`
`1176`	`1177`	`providers: [`
`1177`	`1178`	`{`
`1178`	`1179`	`provide: ErrorHandler,`
Original file line number	Diff line number	Diff line change
`@@ -440,6 +440,7 @@ describe('event listeners', () => {`
`440`	`440`	`}`
`441`	`441`
`442`	`442`	`TestBed.configureTestingModule({`
	`443`	`+ rethrowApplicationErrors: false,`
`443`	`444`	`declarations: [TestCmpt, LikesClicks, ThrowsOnClicks],`
`444`	`445`	`providers: [{provide: ErrorHandler, useClass: CountingErrorHandler}],`
`445`	`446`	`});`