fix(compiler-cli): add interpolatedSignalNotInvoked to diagnostics (#52687)

cexbrayat · thePunderWoman · commit 7a95cccf50c0 · 2023-11-09T15:46:16.000Z
This template diagnostic has been introduced in 8eef694 but was not enabled, as it was not added to `ALL_DIAGNOSTIC_FACTORIES`. PR Close #52687
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/interpolated_signal_not_invoked/index.ts b/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/interpolated_signal_not_invoked/index.ts
@@ -50,7 +50,7 @@ function buildDiagnosticForSignal(
     const templateMapping =
         ctx.templateTypeChecker.getTemplateMappingAtTcbLocation(symbol.tcbLocation)!;
 
-    const errorString = `${node.name} is a function and should be invoked : ${node.name}()`;
+    const errorString = `${node.name} is a function and should be invoked: ${node.name}()`;
     const diagnostic = ctx.makeTemplateDiagnostic(templateMapping.span, errorString);
     return [diagnostic];
   }
diff --git a/packages/compiler-cli/src/ngtsc/typecheck/extended/index.ts b/packages/compiler-cli/src/ngtsc/typecheck/extended/index.ts
@@ -9,6 +9,7 @@
 import {ErrorCode, ExtendedTemplateDiagnosticName} from '../../diagnostics';
 
 import {TemplateCheckFactory} from './api';
+import {factory as interpolatedSignalNotInvoked} from './checks/interpolated_signal_not_invoked';
 import {factory as invalidBananaInBoxFactory} from './checks/invalid_banana_in_box';
 import {factory as missingControlFlowDirectiveFactory} from './checks/missing_control_flow_directive';
 import {factory as missingNgForOfLetFactory} from './checks/missing_ngforof_let';
@@ -21,11 +22,8 @@ export {ExtendedTemplateCheckerImpl} from './src/extended_template_checker';
 
 export const ALL_DIAGNOSTIC_FACTORIES:
     readonly TemplateCheckFactory<ErrorCode, ExtendedTemplateDiagnosticName>[] = [
-      invalidBananaInBoxFactory,
-      nullishCoalescingNotNullableFactory,
-      optionalChainNotNullableFactory,
-      missingControlFlowDirectiveFactory,
-      textAttributeNotBindingFactory,
-      missingNgForOfLetFactory,
-      suffixNotSupportedFactory,
+      invalidBananaInBoxFactory, nullishCoalescingNotNullableFactory,
+      optionalChainNotNullableFactory, missingControlFlowDirectiveFactory,
+      textAttributeNotBindingFactory, missingNgForOfLetFactory, suffixNotSupportedFactory,
+      interpolatedSignalNotInvoked
     ];

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ function buildDiagnosticForSignal(`
`50`	`50`	`const templateMapping =`
`51`	`51`	`ctx.templateTypeChecker.getTemplateMappingAtTcbLocation(symbol.tcbLocation)!;`
`52`	`52`
`53`		- const errorString = `${node.name} is a function and should be invoked : ${node.name}()`;
	`53`	+ const errorString = `${node.name} is a function and should be invoked: ${node.name}()`;
`54`	`54`	`const diagnostic = ctx.makeTemplateDiagnostic(templateMapping.span, errorString);`
`55`	`55`	`return [diagnostic];`
`56`	`56`	`}`