refactor(compiler): remove input transforms feature (#59980)

crisbeto · thePunderWoman · commit 798752b423af · 2025-02-18T19:28:01.000Z
An earlier refactor made the `InputTransformsFeature` a no-op so these changes remove the code that was generating it. PR Close #59980
diff --git a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_input_outputs/input_transform_definition.js b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_input_outputs/input_transform_definition.js
@@ -4,6 +4,5 @@ MyDirective.ɵdir = /*@__PURE__*/ $r3$.ɵɵdefineDirective({
     functionDeclarationInput: [2, "functionDeclarationInput", "functionDeclarationInput", toNumber],
     inlineFunctionInput: [2, "inlineFunctionInput", "inlineFunctionInput", (value, _) => value ? 1 : 0]
   },
-  standalone: false,
-  features: [$r3$.ɵɵInputTransformsFeature]…
+  …
 });
diff --git a/packages/compiler-cli/test/compliance/test_cases/signal_inputs/mixed_input_types.js b/packages/compiler-cli/test/compliance/test_cases/signal_inputs/mixed_input_types.js
@@ -7,6 +7,6 @@ TestDir.ɵdir = /* @__PURE__ */ $r3$.ɵɵdefineDirective({
     decoratorInput: "decoratorInput",
     decoratorInputWithAlias: [0, "publicNameDecorator", "decoratorInputWithAlias"],
     decoratorInputWithTransformAndAlias: [2, "publicNameDecorator2", "decoratorInputWithTransformAndAlias", convertToBoolean]
-  },
+  }
   …
-});
+});
diff --git a/packages/compiler-cli/test/ngtsc/ngtsc_spec.ts b/packages/compiler-cli/test/ngtsc/ngtsc_spec.ts
@@ -10482,7 +10482,6 @@ runInEachFileSystem((os: string) => {
         const dtsContents = env.getContents('test.d.ts');
 
         expect(jsContents).toContain('inputs: { value: [2, "value", "value", toNumber] }');
-        expect(jsContents).toContain('features: [i0.ɵɵInputTransformsFeature]');
         expect(dtsContents).toContain('static ngAcceptInputType_value: boolean | string;');
       });
 
@@ -10507,7 +10506,6 @@ runInEachFileSystem((os: string) => {
         const dtsContents = env.getContents('test.d.ts');
 
         expect(jsContents).toContain('inputs: { value: [2, "value", "value", toNumber] }');
-        expect(jsContents).toContain('features: [i0.ɵɵInputTransformsFeature]');
         expect(dtsContents).toContain('static ngAcceptInputType_value: boolean | string;');
       });
 
@@ -10541,7 +10539,6 @@ runInEachFileSystem((os: string) => {
         const dtsContents = env.getContents('test.d.ts');
 
         expect(jsContents).toContain('inputs: { value: [2, "value", "value", toNumber] }');
-        expect(jsContents).toContain('features: [i0.ɵɵInputTransformsFeature]');
         expect(dtsContents).toContain('import * as i1 from "./types"');
         expect(dtsContents).toContain(
           'static ngAcceptInputType_value: boolean | string | i1.GenericWrapper<string>;',
@@ -10588,7 +10585,6 @@ runInEachFileSystem((os: string) => {
         const dtsContents = env.getContents('test.d.ts');
 
         expect(jsContents).toContain('inputs: { value: [2, "value", "value", toNumber] }');
-        expect(jsContents).toContain('features: [i0.ɵɵInputTransformsFeature]');
         expect(dtsContents).toContain('import * as i1 from "./types"');
         expect(dtsContents).toContain('import * as i2 from "./other-types"');
         expect(dtsContents).toContain(
@@ -10630,7 +10626,6 @@ runInEachFileSystem((os: string) => {
 
         expect(jsContents).toContain(`import { externalToNumber } from 'external';`);
         expect(jsContents).toContain('inputs: { value: [2, "value", "value", externalToNumber] }');
-        expect(jsContents).toContain('features: [i0.ɵɵInputTransformsFeature]');
         expect(dtsContents).toContain('import * as i1 from "external";');
         expect(dtsContents).toContain('static ngAcceptInputType_value: i1.ExternalToNumberType;');
       });
@@ -10668,7 +10663,6 @@ runInEachFileSystem((os: string) => {
         expect(jsContents).toContain(
           'inputs: { value: [2, "value", "value", (value) => value ? 1 : 0] }',
         );
-        expect(jsContents).toContain('features: [i0.ɵɵInputTransformsFeature]');
         expect(dtsContents).toContain('import * as i1 from "external";');
         expect(dtsContents).toContain('static ngAcceptInputType_value: i1.ExternalToNumberType;');
       });
@@ -10701,7 +10695,6 @@ runInEachFileSystem((os: string) => {
         const dtsContents = env.getContents('test.d.ts');
 
         expect(jsContents).toContain('inputs: { value: [2, "value", "value", toBoolean] }');
-        expect(jsContents).toContain('features: [i0.ɵɵInputTransformsFeature]');
         expect(dtsContents).toContain(
           `static ngAcceptInputType_value: boolean | "" | "true" | "false";`,
         );
@@ -10728,7 +10721,6 @@ runInEachFileSystem((os: string) => {
         const dtsContents = env.getContents('test.d.ts');
 
         expect(jsContents).toContain('inputs: { value: [2, "value", "value", toNumber] }');
-        expect(jsContents).toContain('features: [i0.ɵɵInputTransformsFeature]');
         expect(dtsContents).toContain('static ngAcceptInputType_value: boolean | string;');
       });
 
@@ -10753,40 +10745,9 @@ runInEachFileSystem((os: string) => {
         const dtsContents = env.getContents('test.d.ts');
 
         expect(jsContents).toContain('inputs: { value: [2, "value", "value", toNumber] }');
-        expect(jsContents).toContain('features: [i0.ɵɵInputTransformsFeature]');
         expect(dtsContents).toContain('static ngAcceptInputType_value: unknown;');
       });
 
-      it('should insert the InputTransformsFeature before the InheritDefinitionFeature', () => {
-        env.write(
-          '/test.ts',
-          `
-          import {Directive, Input} from '@angular/core';
-
-          function toNumber(value: boolean | string) { return 1; }
-
-          @Directive()
-          export class ParentDir {}
-
-          @Directive()
-          export class Dir extends ParentDir {
-            @Input({transform: toNumber}) value!: number;
-          }
-        `,
-        );
-
-        env.driveMain();
-
-        const jsContents = env.getContents('test.js');
-        const dtsContents = env.getContents('test.d.ts');
-
-        expect(jsContents).toContain('inputs: { value: [2, "value", "value", toNumber] }');
-        expect(jsContents).toContain(
-          'features: [i0.ɵɵInputTransformsFeature, i0.ɵɵInheritDefinitionFeature]',
-        );
-        expect(dtsContents).toContain('static ngAcceptInputType_value: boolean | string;');
-      });
-
       it('should compile an input with using an ambient type in the transform function', () => {
         env.write(
           'node_modules/external/index.d.ts',
@@ -10818,7 +10779,6 @@ runInEachFileSystem((os: string) => {
         expect(jsContents).toContain(
           'inputs: { element: [2, "element", "element", coerceElement] }',
         );
-        expect(jsContents).toContain('features: [i0.ɵɵInputTransformsFeature]');
         expect(dtsContents).toContain(
           'static ngAcceptInputType_element: HTMLElement | i0.ElementRef<HTMLElement>;',
         );
diff --git a/packages/compiler/src/render3/r3_identifiers.ts b/packages/compiler/src/render3/r3_identifiers.ts
@@ -551,11 +551,6 @@ export class Identifiers {
     moduleName: CORE,
   };
 
-  static InputTransformsFeatureFeature: o.ExternalReference = {
-    name: 'ɵɵInputTransformsFeature',
-    moduleName: CORE,
-  };
-
   static ExternalStylesFeature: o.ExternalReference = {
     name: 'ɵɵExternalStylesFeature',
     moduleName: CORE,
diff --git a/packages/compiler/src/render3/view/compiler.ts b/packages/compiler/src/render3/view/compiler.ts
@@ -114,7 +114,6 @@ function addFeatures(
 
   const providers = meta.providers;
   const viewProviders = (meta as R3ComponentMetadata<R3TemplateDependency>).viewProviders;
-  const inputKeys = Object.keys(meta.inputs);
 
   if (providers || viewProviders) {
     const args = [providers || new o.LiteralArrayExpr([])];
@@ -123,12 +122,6 @@ function addFeatures(
     }
     features.push(o.importExpr(R3.ProvidersFeature).callFn(args));
   }
-  for (const key of inputKeys) {
-    if (meta.inputs[key].transformFunction !== null) {
-      features.push(o.importExpr(R3.InputTransformsFeatureFeature));
-      break;
-    }
-  }
   // Note: host directives feature needs to be inserted before the
   // inheritance feature to ensure the correct execution order.
   if (meta.hostDirectives?.length) {
diff --git a/packages/core/src/core_render3_private_export.ts b/packages/core/src/core_render3_private_export.ts
@@ -116,7 +116,6 @@ export {
   ɵɵi18nPostprocess,
   ɵɵi18nStart,
   ɵɵInheritDefinitionFeature,
-  ɵɵInputTransformsFeature,
   ɵɵinjectAttribute,
   ɵɵInjectorDeclaration,
   ɵɵinvalidFactory,
diff --git a/packages/core/src/render3/features/input_transforms_feature.ts b/packages/core/src/render3/features/input_transforms_feature.ts
diff --git a/packages/core/src/render3/index.ts b/packages/core/src/render3/index.ts
@@ -9,7 +9,6 @@ import {ɵɵdefineComponent, ɵɵdefineDirective, ɵɵdefineNgModule, ɵɵdefine
 import {ɵɵCopyDefinitionFeature} from './features/copy_definition_feature';
 import {ɵɵHostDirectivesFeature} from './features/host_directives_feature';
 import {ɵɵInheritDefinitionFeature} from './features/inherit_definition_feature';
-import {ɵɵInputTransformsFeature} from './features/input_transforms_feature';
 import {ɵɵNgOnChangesFeature} from './features/ng_onchanges_feature';
 import {ɵɵProvidersFeature} from './features/providers_feature';
 import {ɵɵExternalStylesFeature} from './features/external_styles_feature';
@@ -246,7 +245,6 @@ export {
   ɵɵHostDirectivesFeature,
   ɵɵInheritDefinitionFeature,
   ɵɵInjectorDeclaration,
-  ɵɵInputTransformsFeature,
   ɵɵNgModuleDeclaration,
   ɵɵNgOnChangesFeature,
   ɵɵPipeDeclaration,
diff --git a/packages/core/src/render3/jit/environment.ts b/packages/core/src/render3/jit/environment.ts
@@ -49,7 +49,6 @@ export const angularCoreEnv: {[name: string]: unknown} = (() => ({
   'ɵɵProvidersFeature': r3.ɵɵProvidersFeature,
   'ɵɵCopyDefinitionFeature': r3.ɵɵCopyDefinitionFeature,
   'ɵɵInheritDefinitionFeature': r3.ɵɵInheritDefinitionFeature,
-  'ɵɵInputTransformsFeature': r3.ɵɵInputTransformsFeature,
   'ɵɵExternalStylesFeature': r3.ɵɵExternalStylesFeature,
   'ɵɵnextContext': r3.ɵɵnextContext,
   'ɵɵnamespaceHTML': r3.ɵɵnamespaceHTML,
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -727,7 +727,6 @@
   "{isArray:isArray2}",
   "{isArray:isArray}",
   "ɵEmptyOutletComponent",
-  "ɵɵInputTransformsFeature",
   "ɵɵNgOnChangesFeature",
   "ɵɵattribute",
   "ɵɵdefineComponent",
diff --git a/packages/core/test/render3/jit/declare_component_spec.ts b/packages/core/test/render3/jit/declare_component_spec.ts
@@ -23,7 +23,6 @@ import {
   AttributeMarker,
   ComponentDef,
   ɵɵInheritDefinitionFeature,
-  ɵɵInputTransformsFeature,
   ɵɵNgOnChangesFeature,
 } from '../../../src/render3';
 
@@ -106,7 +105,6 @@ describe('component declaration jit compilation', () => {
       declaredInputs: {
         'bindingName': 'classProperty',
       },
-      features: [ɵɵInputTransformsFeature],
     });
   });
 
